Bug 139231

Summary:

Provide a sample plugin to demonstrate the mute plugin API

Product:

WebKit

Reporter:

Ada Chan <adachan>

Component:

Plug-ins

Assignee:

Ada Chan <adachan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adachan, andersca, commit-queue, kdecker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=137219
https://bugs.webkit.org/show_bug.cgi?id=138105

Attachments:

Description	Flags
Patch	none
Fixed some style issues	none
Fixed some style issues	andersca: review+

Ada Chan

Reported 2014-12-03 12:49:18 PST

See https://bugs.webkit.org/show_bug.cgi?id=138105 and https://bugs.webkit.org/show_bug.cgi?id=137219 about the mute plugin API.

Attachments
Patch (46.22 KB, patch) 2014-12-03 12:56 PST, Ada Chan	no flags	Details Formatted Diff Diff
Fixed some style issues (45.81 KB, patch) 2014-12-03 13:14 PST, Ada Chan	no flags	Details Formatted Diff Diff
Fixed some style issues (45.76 KB, patch) 2014-12-03 13:27 PST, Ada Chan	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ada Chan

Comment 1 2014-12-03 12:56:46 PST

Created attachment 242514 [details] Patch

WebKit Commit Bot

Comment 2 2014-12-03 12:57:52 PST

Attachment 242514 [details] did not pass style-queue: ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:34: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:42: Should not have spaces around = in property synthesis. [whitespace/property] [4] ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:111: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:40: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:65: The parameter name "saved" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:66: The parameter name "save" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:67: The parameter name "window" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:68: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:68: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:69: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:69: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:70: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:71: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:72: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:75: The parameter name "reason" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:76: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:77: The parameter name "variable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:82: The parameter name "pluginFuncs" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:86: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:236: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:303: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:351: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:350: Missing space before ( in switch( [whitespace/parens] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:390: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:405: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Examples/NetscapeMuteAPIPlugin/MenuHandler.m:34: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 32 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ada Chan

Comment 3 2014-12-03 13:14:30 PST

Created attachment 242515 [details] Fixed some style issues

WebKit Commit Bot

Comment 4 2014-12-03 13:17:07 PST

Attachment 242515 [details] did not pass style-queue: ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:34: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:113: More than one command on the same line [whitespace/newline] [4] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:69: The parameter name "stream" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:385: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Examples/NetscapeMuteAPIPlugin/main.m:400: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Examples/NetscapeMuteAPIPlugin/MenuHandler.m:34: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 6 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ada Chan

Comment 5 2014-12-03 13:27:48 PST

Created attachment 242517 [details] Fixed some style issues

WebKit Commit Bot

Comment 6 2014-12-03 13:30:57 PST

Attachment 242517 [details] did not pass style-queue: ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:34: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Examples/NetscapeMuteAPIPlugin/AudioPlayer.mm:113: More than one command on the same line [whitespace/newline] [4] ERROR: Examples/NetscapeMuteAPIPlugin/MenuHandler.m:34: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ada Chan

Comment 7 2014-12-03 22:43:38 PST

Committed: http://trac.webkit.org/changeset/176785

Note You need to log in before you can comment on or make changes to this bug.