Bug 139230

Summary: The parser should allocate all pieces of the AST
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch oliver: review+

Geoffrey Garen
Reported 2014-12-03 11:36:29 PST
The parser should allocate all pieces of the AST
Attachments
Patch (23.67 KB, patch)
2014-12-03 11:47 PST, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2014-12-03 11:47:57 PST
Created attachment 242509 [details] Patch
Oliver Hunt
Comment 2 2014-12-03 12:04:42 PST
Comment on attachment 242509 [details] Patch r=me. There's so much cruft left over from the old bison parser :(
Mark Lam
Comment 3 2014-12-03 12:19:30 PST
Comment on attachment 242509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242509&action=review > Source/JavaScriptCore/parser/ASTBuilder.h:322 > + PropertyNode* createProperty(VM*, double propertyName, ExpressionNode* node, PropertyNode::Type type, bool) is there a reason this unused VM* arg can't be removed?
Geoffrey Garen
Comment 4 2014-12-03 12:29:25 PST
> > Source/JavaScriptCore/parser/ASTBuilder.h:322 > > + PropertyNode* createProperty(VM*, double propertyName, ExpressionNode* node, PropertyNode::Type type, bool) > > is there a reason this unused VM* arg can't be removed? Though ASTBuilder uses its m_vm data member instead of the VM* argument, SyntaxChecker does not have an m_vm data member, and does use the VM* argument. This is an oddity that could use cleaning up, but I didn't clean it up in this patch.
Geoffrey Garen
Comment 5 2014-12-03 13:54:22 PST
Committed r176754: <http://trac.webkit.org/changeset/176754>
Note You need to log in before you can comment on or make changes to this bug.