| Summary: | The parser should allocate all pieces of the AST | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, oliver, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Geoffrey Garen
2014-12-03 11:36:29 PST
Created attachment 242509 [details]
Patch
Comment on attachment 242509 [details]
Patch
r=me. There's so much cruft left over from the old bison parser :(
Comment on attachment 242509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242509&action=review > Source/JavaScriptCore/parser/ASTBuilder.h:322 > + PropertyNode* createProperty(VM*, double propertyName, ExpressionNode* node, PropertyNode::Type type, bool) is there a reason this unused VM* arg can't be removed? > > Source/JavaScriptCore/parser/ASTBuilder.h:322
> > + PropertyNode* createProperty(VM*, double propertyName, ExpressionNode* node, PropertyNode::Type type, bool)
>
> is there a reason this unused VM* arg can't be removed?
Though ASTBuilder uses its m_vm data member instead of the VM* argument, SyntaxChecker does not have an m_vm data member, and does use the VM* argument.
This is an oddity that could use cleaning up, but I didn't clean it up in this patch.
Committed r176754: <http://trac.webkit.org/changeset/176754> |