Bug 139227

Summary: [iOS] allow host application to opt-out of alternate fullscreen pt. 2
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, glenn, jeremyj-wk, jer.noble, philipj, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Description Eric Carlson 2014-12-03 11:14:33 PST 
Pass the setting added in r176199 to AVKit.
Comment 1 Eric Carlson 2014-12-03 11:48:48 PST 
Created attachment 242510 [details]
Proposed patch.
Comment 2 Jeremy Jones 2014-12-03 12:04:41 PST 
r=me
Comment 3 Jer Noble 2014-12-03 13:10:31 PST 
Comment on attachment 242510 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=242510&action=review

r=me, but needs a 👍 from a WK2 owner for the WK2 changes.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:84
> -    WEBCORE_EXPORT virtual void setupFullscreen(PlatformLayer&, IntRect initialRect, UIView *, HTMLMediaElement::VideoFullscreenMode);
> +    WEBCORE_EXPORT virtual void setupFullscreen(PlatformLayer&, IntRect initialRect, UIView *, HTMLMediaElement::VideoFullscreenMode, bool);

Why no parameter name here?

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h:58
> -    void setupFullscreenWithID(uint32_t, WebCore::IntRect initialRect, float hostingDeviceScaleFactor, uint32_t videoFullscreenMode);
> +    void setupFullscreenWithID(uint32_t, WebCore::IntRect initialRect, float hostingDeviceScaleFactor, uint32_t videoFullscreenMode, bool);

Why no parameter name here?
Comment 4 Anders Carlsson 2014-12-03 18:43:04 PST 
Looks good! I agree with Jer that you should name the boolean parameters though.
Comment 5 Eric Carlson 2014-12-05 05:33:23 PST 
rdar://problem/19155999
Comment 6 Eric Carlson 2014-12-05 05:33:53 PST 
Committed r176841: https://trac.webkit.org/r176841