Bug 139227

Summary: [iOS] allow host application to opt-out of alternate fullscreen pt. 2
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, glenn, jeremyj-wk, jer.noble, philipj, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2014-12-03 11:14:33 PST
Pass the setting added in r176199 to AVKit.
Attachments
Proposed patch. (11.22 KB, patch)
2014-12-03 11:48 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-12-03 11:48:48 PST
Created attachment 242510 [details] Proposed patch.
Jeremy Jones
Comment 2 2014-12-03 12:04:41 PST
r=me
Jer Noble
Comment 3 2014-12-03 13:10:31 PST
Comment on attachment 242510 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=242510&action=review r=me, but needs a 👍 from a WK2 owner for the WK2 changes. > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:84 > - WEBCORE_EXPORT virtual void setupFullscreen(PlatformLayer&, IntRect initialRect, UIView *, HTMLMediaElement::VideoFullscreenMode); > + WEBCORE_EXPORT virtual void setupFullscreen(PlatformLayer&, IntRect initialRect, UIView *, HTMLMediaElement::VideoFullscreenMode, bool); Why no parameter name here? > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h:58 > - void setupFullscreenWithID(uint32_t, WebCore::IntRect initialRect, float hostingDeviceScaleFactor, uint32_t videoFullscreenMode); > + void setupFullscreenWithID(uint32_t, WebCore::IntRect initialRect, float hostingDeviceScaleFactor, uint32_t videoFullscreenMode, bool); Why no parameter name here?
Anders Carlsson
Comment 4 2014-12-03 18:43:04 PST
Looks good! I agree with Jer that you should name the boolean parameters though.
Eric Carlson
Comment 5 2014-12-05 05:33:23 PST
rdar://problem/19155999
Eric Carlson
Comment 6 2014-12-05 05:33:53 PST
Committed r176841: https://trac.webkit.org/r176841
Note You need to log in before you can comment on or make changes to this bug.