Bug 139224

Summary: REGRESSION(r176687): Caused webkit2 test assertion failure crashes in WebKit::WebPage::willStartDrag()
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, mitz
Priority: P1 Keywords: LayoutTestFailure, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Wait for the UI process to begin dragging if needed before handling a synthetic synchronous mouse event ap: review+

Description Mark Lam 2014-12-03 09:22:43 PST
The following tests started crashing with assertion failures after r176687:

fast/events/clear-drag-state.html
fast/css/user-drag-none.html
editing/pasteboard/dataTransfer-setData-getData.html
editing/pasteboard/drop-text-events-sideeffect-crash.html
editing/pasteboard/drag-drop-iframe-refresh-crash.html
editing/pasteboard/drop-text-events-sideeffect.html
editing/selection/user-drag-element-and-user-select-none.html
Comment 1 Mark Lam 2014-12-03 09:52:37 PST
Updated TestExpectations to expect crashes for these tests in r176723: <http://trac.webkit.org/r176723>.
Comment 2 Alexey Proskuryakov 2014-12-03 09:59:05 PST
I think that a Skip expectation would be more appropriate. Seven tests that crash every time make bots substantially slower, and I suspect that the high system load associated with creating crash logs may destabilize other tests too.

So, the better expectations would be (note how they can be limited to debug builds only):

webkit.org/b/139224 [ Debug ] fast/events/clear-drag-state.html [ Skip ]
...
Comment 3 Alexey Proskuryakov 2014-12-03 10:00:02 PST
Also, crashes make running tests locally very annoying.
Comment 4 Mark Lam 2014-12-03 10:33:56 PST
Updated TestExpectations to skip tests per Alexey's instructions in r176726: <http://trac.webkit.org/r176726>.
Comment 5 mitz 2014-12-03 10:53:50 PST
Created attachment 242503 [details]
Wait for the UI process to begin dragging if needed before handling a synthetic synchronous mouse event
Comment 6 mitz 2014-12-03 11:08:36 PST
Fixed in <http://trac.webkit.org/r176728>.