Bug 139213

Summary: Add a stubbed out version of WebStorageNamespaceProvider
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Anders Carlsson 2014-12-02 16:50:52 PST
Add a stubbed out version of WebStorageNamespaceProvider
Comment 1 Anders Carlsson 2014-12-02 16:54:27 PST
Created attachment 242464 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-02 16:57:23 PST
Attachment 242464 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-12-02 17:50:29 PST
Created attachment 242471 [details]
Patch
Comment 4 Anders Carlsson 2014-12-02 18:30:33 PST
Created attachment 242474 [details]
Patch
Comment 5 WebKit Commit Bot 2014-12-02 18:32:12 PST
Attachment 242474 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2014-12-05 16:56:12 PST
Created attachment 242681 [details]
Patch
Comment 7 WebKit Commit Bot 2014-12-05 16:58:38 PST
Attachment 242681 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Anders Carlsson 2014-12-06 09:48:03 PST
Created attachment 242715 [details]
Patch
Comment 9 WebKit Commit Bot 2014-12-06 09:50:49 PST
Attachment 242715 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2014-12-06 13:27:07 PST
Comment on attachment 242715 [details]
Patch

Clearing flags on attachment: 242715

Committed r176913: <http://trac.webkit.org/changeset/176913>
Comment 11 WebKit Commit Bot 2014-12-06 13:27:10 PST
All reviewed patches have been landed.  Closing bug.