Summary: | [GTK] Missing API detected in GObject DOM bindings after r176630 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||||||||
Component: | WebKitGTK | Assignee: | Dean Jackson <dino> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cgarcia, dino, galineau, gustavo, mrobinson | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2014-12-02 14:43:12 PST
Yeah, sorry. I should have noticed this in review. We should add innerHTML back onto HTMLElement and have it call up to the Element implementation. Created attachment 242484 [details]
Patch
Instead of exposing it in both classes, we could add custom compatible API to the GObject DOM bindings. Or is that also needed for Objc bindings? (In reply to comment #3) > Instead of exposing it in both classes, we could add custom compatible API > to the GObject DOM bindings. Or is that also needed for Objc bindings? Yeah, that might be easier. I think we could do the same in the ObjC bindings. I'll take a look. (In reply to comment #4) > (In reply to comment #3) > > Instead of exposing it in both classes, we could add custom compatible API > > to the GObject DOM bindings. Or is that also needed for Objc bindings? > > Yeah, that might be easier. I think we could do the same in the ObjC > bindings. I'll take a look. Actually I'm not so sure how to do this for ObjC yet :( Created attachment 242499 [details]
Patch
Weinig suggested that we follow cgarcia's advice and just add it to the GObject DOM bindings, but I'm not sure how to do that. Sorry, but I'll leave it to you guys :( (In reply to comment #7) > Weinig suggested that we follow cgarcia's advice and just add it to the > GObject DOM bindings, but I'm not sure how to do that. > > Sorry, but I'll leave it to you guys :( Don't worry, I'll do it Created attachment 242557 [details]
Patch
Created attachment 242558 [details]
Try to fix GTK build
I wonder why it built for me
EWS failure must be caused by previous patches, it builds fine here I know what the problem is with EWS. The new symbols in Element were added as unstable API by default, and the patch is now moving them as stable, but changes in the symbol file don't cause the bindings to be regenerated, so the symbols are still in WebKitDOMElementUnstable.h. The ideal solution would be to make the symbols file a dependency of the dom bindings generation, but bindings are generated in a common macro, so I'm not sure how to do that. A clean build would also fix the problem, of course. (In reply to comment #12) > I know what the problem is with EWS. The new symbols in Element were added > as unstable API by default, and the patch is now moving them as stable, but > changes in the symbol file don't cause the bindings to be regenerated, so > the symbols are still in WebKitDOMElementUnstable.h. The ideal solution > would be to make the symbols file a dependency of the dom bindings > generation, but bindings are generated in a common macro, so I'm not sure > how to do that. A clean build would also fix the problem, of course. One option is to add an extra argument to GENERATE_BINDINGS which enables you to specify extra dependencies for all of the targets. Created attachment 242626 [details]
Updated patch
Changed the GENERATE_BINDINGS, let's see whether this works
Comment on attachment 242626 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=242626&action=review OK =) > Source/WebCore/ChangeLog:24 > +2014-12-04 Carlos Garcia Campos <cgarcia@igalia.com> Duplicate ChangeLog entry. (In reply to comment #15) > Comment on attachment 242626 [details] > Updated patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242626&action=review > > OK =) Thanks > > Source/WebCore/ChangeLog:24 > > +2014-12-04 Carlos Garcia Campos <cgarcia@igalia.com> > > Duplicate ChangeLog entry. Oops Committed r176919: <http://trac.webkit.org/changeset/176919> |