Bug 139199

Summary:

[Quirks mode only] "Do not trim trailing whitespace followed by " quirk causes lines to stretch

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, ahmad.saleem792, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, glenn, jbedard, jcraig, jdiggs, koivisto, samuel_white, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Safari-Rendering	none
FireFox Rendering	none
Test Case	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none

Said Abou-Hallawa

Reported 2014-12-02 14:32:08 PST

Created attachment 242447 [details] Safari-Rendering Open the following html in WebKit: <html> <body> <img height="10" width="100" style="border: 1px solid blue"> <img height="100" width="10" style="border: 1px solid purple"> <img height="10" width="100%" style="border: 1px solid blue"> <img height="100" width="10" style="border: 1px solid purple"> </body> </html> Result: The first two image rectangles do not touch with other image rectangles. But the last two rectangles touch each other. Expected: In FireFox and IE, the four image rectangles touch each other. It looks like in WebKit, when forces a new line creation (the first two images), the descent of the font is added to the line runs height. But when the a new line is created because of wrapping (the third image), nothing is added to the runs height.

Attachments
Safari-Rendering (15.87 KB, image/png) 2014-12-02 14:32 PST, Said Abou-Hallawa	no flags	Details
FireFox Rendering (43.66 KB, image/png) 2014-12-02 14:32 PST, Said Abou-Hallawa	no flags	Details
Test Case (310 bytes, text/html) 2015-02-05 13:03 PST, Benjamin Poulain	no flags	Details
Patch (5.25 KB, patch) 2023-04-21 08:54 PDT, alan	no flags	Details Formatted Diff Diff
Patch (124.25 KB, patch) 2023-04-22 06:17 PDT, alan	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (561.59 KB, patch) 2023-04-22 07:26 PDT, alan	no flags	Details Formatted Diff Diff
Patch (1.04 MB, patch) 2023-04-22 09:24 PDT, alan	no flags	Details Formatted Diff Diff
Patch (1.05 MB, patch) 2023-04-22 14:46 PDT, alan	no flags	Details Formatted Diff Diff
Patch (1.06 MB, patch) 2023-04-22 19:40 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2014-12-02 14:32:36 PST

Created attachment 242449 [details] FireFox Rendering

Radar WebKit Bug Importer

Comment 2 2014-12-02 14:33:40 PST

<rdar://problem/19119909>

Benjamin Poulain

Comment 3 2015-02-05 13:03:05 PST

Created attachment 246125 [details] Test Case

Ahmad Saleem

Comment 4 2023-04-21 07:56:47 PDT

I am still able to reproduce this bug in Safari Technology Preview 168 and WebKit ToT similar to attached reference screenshots while Chrome Canary 115 and Firefox Nightly 114 match each other.

alan

Comment 5 2023-04-21 08:54:30 PDT

Created attachment 466030 [details] Patch

alan

Comment 6 2023-04-21 08:55:08 PDT

Let's remove this legacy quirk and see what breaks (needs rebaseline)

alan

Comment 7 2023-04-21 10:57:34 PDT

lolz, now I know why I chose to implement this quirk in IFC.

alan

Comment 8 2023-04-22 06:17:11 PDT

Created attachment 466041 [details] Patch