Summary: | Should use standardQuickLookMenuItem for apps that don't implement customizations | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, cdumez, commit-queue, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Beth Dakin
2014-12-02 12:23:10 PST
Created attachment 242440 [details]
Patch
Attachment 242440 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/mac/QuickLookMacSPI.h:50: Tab found; better to use spaces [whitespace/tab] [1]
ERROR: Source/WebCore/platform/spi/mac/QuickLookMacSPI.h:51: Tab found; better to use spaces [whitespace/tab] [1]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thank you! http://trac.webkit.org/changeset/176684 I am getting build errors after this patch (despite the recent build fixes): Source/WebKit/mac/WebView/WebActionMenuController.mm:80:40: error: cannot find protocol declaration for 'QLPreviewMenuItemDelegate'; did you mean 'QLPreviewPanelDelegate'? @interface WebActionMenuController () <QLPreviewMenuItemDelegate> ^~~~~~~~~~~~~~~~~~~~~~~~~ QLPreviewPanelDelegate Source/WebKit/mac/WebView/WebActionMenuController.mm:290:28: error: 'QLPreviewMenuItem' may not respond to 'setDelegate:' [-Werror] [qlPreviewLinkItem setDelegate:self]; ~~~~~~~~~~~~~~~~~ ^ Source/WebKit/mac/WebView/WebActionMenuController.mm:290:40: error: cannot initialize a parameter of type 'id<NSFileManagerDelegate>' with an lvalue of type 'WebActionMenuController *' [qlPreviewLinkItem setDelegate:self]; ^~~~ ^ 3 errors generated. |