Bug 139189

Summary: Remove more Windows cruft
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ossy, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch kling: review+

Anders Carlsson
Reported 2014-12-02 11:05:50 PST
Remove more Windows cruft
Attachments
Patch (3.16 KB, patch)
2014-12-02 11:06 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (3.71 KB, patch)
2014-12-02 11:49 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (3.89 KB, patch)
2014-12-02 12:21 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (4.43 KB, patch)
2014-12-02 12:51 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-12-02 11:06:08 PST
Created attachment 242431 [details] Patch
Anders Carlsson
Comment 2 2014-12-02 11:49:00 PST
Created attachment 242435 [details] Patch
Anders Carlsson
Comment 3 2014-12-02 12:21:57 PST
Created attachment 242439 [details] Patch
Anders Carlsson
Comment 4 2014-12-02 12:51:31 PST
Created attachment 242442 [details] Patch
Andreas Kling
Comment 5 2014-12-02 12:52:29 PST
Comment on attachment 242442 [details] Patch r=me
Anders Carlsson
Comment 6 2014-12-02 12:53:21 PST
Committed r176686: <http://trac.webkit.org/changeset/176686>
Csaba Osztrogonác
Comment 7 2014-12-03 08:05:57 PST
(In reply to comment #6) > Committed r176686: <http://trac.webkit.org/changeset/176686> It made 50+ tests crash on the Windows bot: - https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/48554
Csaba Osztrogonác
Comment 8 2014-12-04 09:45:27 PST
The Windows bots are still bleeding. Are you going to fix them?
Anders Carlsson
Comment 9 2014-12-04 09:46:29 PST
They just need a clean build.
Csaba Osztrogonác
Comment 10 2014-12-04 09:49:47 PST
(In reply to comment #9) > They just need a clean build. No. I triggered a clean build here: - https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/65753 (compile failed because win doesn't produce output in 20 minutes and build master kills it) - https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/65754 - build: OK - test: https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/48570 - still failures after clean build
Csaba Osztrogonác
Comment 11 2014-12-05 07:03:14 PST
The bots are still bleeding. Are you going to fix it? But now the build is broken too - after you broke it, see https://bugs.webkit.org/show_bug.cgi?id=139297 for details.
Note You need to log in before you can comment on or make changes to this bug.