Summary: | Remove more Windows cruft | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, ossy, roger_fong | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Anders Carlsson
2014-12-02 11:05:50 PST
Created attachment 242431 [details]
Patch
Created attachment 242435 [details]
Patch
Created attachment 242439 [details]
Patch
Created attachment 242442 [details]
Patch
Comment on attachment 242442 [details]
Patch
r=me
Committed r176686: <http://trac.webkit.org/changeset/176686> (In reply to comment #6) > Committed r176686: <http://trac.webkit.org/changeset/176686> It made 50+ tests crash on the Windows bot: - https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/48554 The Windows bots are still bleeding. Are you going to fix them? They just need a clean build. (In reply to comment #9) > They just need a clean build. No. I triggered a clean build here: - https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/65753 (compile failed because win doesn't produce output in 20 minutes and build master kills it) - https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/65754 - build: OK - test: https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/48570 - still failures after clean build The bots are still bleeding. Are you going to fix it? But now the build is broken too - after you broke it, see https://bugs.webkit.org/show_bug.cgi?id=139297 for details. |