| Summary: | createHTMLDocument in DOMImplementation should be as per the DOM4 specification | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Shivakumar J M <shiva.jm> | ||||||||
| Component: | DOM | Assignee: | Shivakumar J M <shiva.jm> | ||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||
| Severity: | Normal | CC: | ap, buildbot, cdumez, commit-queue, esprehn+autocc, kangil.han, rniwa, zcorpan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Shivakumar J M
2014-12-02 01:58:52 PST
Created attachment 242397 [details]
Patch
make createHTMLDocument in DOMImplementation should be as per the DOM4 specification.
Comment on attachment 242397 [details] Patch Attachment 242397 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4703486423859200 New failing tests: imported/w3c/html-templates/serializing-html-templates/outerhtml.html fast/dom/HTMLDocument/clone-node-quirks-mode.html fast/dom/DOMImplementation/createHTMLDocument-optional-title.html Created attachment 242402 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 242397 [details] Patch Attachment 242397 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6645837601964032 New failing tests: imported/w3c/html-templates/serializing-html-templates/outerhtml.html fast/dom/HTMLDocument/clone-node-quirks-mode.html fast/dom/DOMImplementation/createHTMLDocument-optional-title.html Created attachment 242404 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 242397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242397&action=review > Source/WebCore/ChangeLog:10 > + No new tests, no behavior change. If this doesn't change behavior, why are you making this change? What is the upshot of it? Comment on attachment 242397 [details]
Patch
Hi,
Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.
To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.
STP passes http://web-platform.test:8000/dom/nodes/DOMImplementation-createHTMLDocument.html for me so maybe this has already been fixed? *** This bug has been marked as a duplicate of bug 153374 *** |