Bug 139174

Summary: [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 139321    
Bug Blocks:    
Attachments:
Description Flags
proposed fix
simon.fraser: review+
with Windows fixes none

Description Alexey Proskuryakov 2014-12-01 23:33:48 PST 
We set CrashReporter information on each main frame navigation. This means that tests that perform a navigation and then crash end up having a post-navigation URL in the report, which is often not unique, and thus hard to map back to the actual crashing test.
Comment 1 Alexey Proskuryakov 2014-12-02 00:02:40 PST 
Created attachment 242390 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-12-02 00:05:07 PST 
Attachment 242390 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/mac/DumpRenderTree.mm:62:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/DumpRenderTree/mac/DumpRenderTree.mm:1790:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-12-02 08:54:33 PST 
Comment on attachment 242390 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=242390&action=review

> Tools/ChangeLog:19
> +        reporter informaiton here.

informaiton
Comment 4 Alexey Proskuryakov 2014-12-02 10:09:27 PST 
Created attachment 242423 [details]
with Windows fixes

Turns out that Windows DumpRenderTree actually still used paths in pathOrURL. This inconsistency seems easy to fix, let's see what EWS thinks.
Comment 5 WebKit Commit Bot 2014-12-02 11:30:33 PST 
Comment on attachment 242423 [details]
with Windows fixes

Clearing flags on attachment: 242423

Committed r176677: <http://trac.webkit.org/changeset/176677>
Comment 6 WebKit Commit Bot 2014-12-02 11:30:37 PST 
All reviewed patches have been landed.  Closing bug.