Summary: | Crash when setting 'column-span' CSS property to 'calc(2 * 3)' | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, darin, kling, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 138778 | ||||||
Attachments: |
|
Description
Chris Dumez
2014-12-01 19:08:07 PST
Created attachment 242381 [details]
Patch
Comment on attachment 242381 [details]
Patch
I’m really concerned about the fragility of the way parsedDouble is written. It seems super strange to pass in a value but separately have a side bit of global state for the calculated value. We need to fix this, because this code is way too easy to get wrong. Maybe this should all be global state, rather than passing a value pointer around. Or we could go the other way and pass the calculated value around.
(In reply to comment #2) > Comment on attachment 242381 [details] > Patch > > I’m really concerned about the fragility of the way parsedDouble is written. > It seems super strange to pass in a value but separately have a side bit of > global state for the calculated value. We need to fix this, because this > code is way too easy to get wrong. Maybe this should all be global state, > rather than passing a value pointer around. Or we could go the other way and > pass the calculated value around. Yes, I agree this needs to be refactored. It is on my TODO list. Comment on attachment 242381 [details] Patch Clearing flags on attachment: 242381 Committed r176671: <http://trac.webkit.org/changeset/176671> All reviewed patches have been landed. Closing bug. |