Bug 139167

Summary:

Make InternalFunction inherit from JSCallee so that it has a JSScope

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED WONTFIX

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

136724

Attachments:

Description	Flags
Patch	none
Fixed ChangeLog comment	ggaren: review-

Description Michael Saboff 2014-12-01 17:52:30 PST

InternalFunction is currently the only Callee type that doesn't have a JSScope.  This is to change InternalFunction to inherit from JSCallee so that it has a scope like all other callee types.

Comment 1 Michael Saboff 2014-12-01 18:03:02 PST

Created attachment 242373 [details]
Patch

Comment 2 Michael Saboff 2014-12-01 18:07:29 PST

Created attachment 242374 [details]
Fixed ChangeLog comment

Comment 3 Geoffrey Garen 2014-12-02 12:34:36 PST

Comment on attachment 242374 [details]
Fixed ChangeLog comment

I don't think it helps to make InternalFunction have a JSScope. The VM must handle callees that are not subclasses of JSCallee, since arbitrary callees are allowed in the language / DOM API -- for example, document.all(1).