Bug 139161

Summary:

Clients need a way to explicitly set the title of a page preview

Product:

WebKit

Reporter:

Conrad Shultz <conrad_shultz>

Component:

WebKit2

Assignee:

Conrad Shultz <conrad_shultz>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, conrad_shultz, mitz, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bdakin: review+

Conrad Shultz

Reported 2014-12-01 16:18:37 PST

Clients need a way to explicitly set the title of a page preview. This will allow clients to change the title after the initial page load if needed.

Attachments
Patch (7.84 KB, patch) 2014-12-01 16:21 PST, Conrad Shultz	bdakin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-12-01 16:19:27 PST

Conrad Shultz

Comment 2 2014-12-01 16:21:08 PST

Conrad Shultz

Comment 3 2014-12-01 16:29:51 PST

Comment on attachment 242360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242360&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:130 > + _previewTitle = [previewTitle copy]; Oh, I think this needs adoptNS. Will add before landing.

Conrad Shultz

Comment 4 2014-12-01 16:49:23 PST

Note You need to log in before you can comment on or make changes to this bug.