Bug 139156

Summary:

Add action menu tests

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, commit-queue, conrad_shultz, sam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	dino: review+

Description Tim Horton 2014-12-01 14:58:05 PST

Add action menu tests

Comment 1 Tim Horton 2014-12-01 14:59:24 PST

Created attachment 242350 [details]
Patch

Comment 2 WebKit Commit Bot 2014-12-01 15:00:30 PST

Attachment 242350 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:69:  Missing space after ,  [whitespace/comma] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:214:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:221:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:295:  Missing space after ,  [whitespace/comma] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:319:  Missing space after ,  [whitespace/comma] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:481:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:489:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:497:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:505:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:513:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:519:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:527:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:535:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:547:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:600:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:608:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:616:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:628:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:640:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:652:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:663:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:670:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:680:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:692:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:701:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:707:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:713:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:723:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:732:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:737:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 32 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Tim Horton 2014-12-04 02:28:49 PST

Created attachment 242561 [details]
Patch

Comment 4 WebKit Commit Bot 2014-12-04 02:31:59 PST

Attachment 242561 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:476:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:484:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:492:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:500:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:508:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:514:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:522:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:530:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:542:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:554:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:562:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:570:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:582:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:594:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:602:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:610:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:622:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:634:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:646:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:657:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:664:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:674:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:686:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:695:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:703:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:709:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:719:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:728:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:733:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 31 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Dean Jackson 2014-12-05 11:43:47 PST

Comment on attachment 242561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242561&action=review

mostly-rubber-stamped = me

> Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:196
> +        NSArray *pasteboardItems = [[NSPasteboard generalPasteboard] readObjectsForClasses:@[ [NSImage class] ] options:nil];

Why whitespace around [NSImage class]?

> Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:368
> +static NSPoint windowPointForTarget(TargetType target)
> +{
> +    NSPoint contentPoint;
> +    switch (target) {

This method seems so dodgy/fragile :)

> Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:44
> +#define SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(framework) \

Maybe all these should be in a separate header file?

> Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:126
> +
> +

Extra space! :)

> Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:141
> +    RetainPtr<CFArrayRef> results = adoptCF(DDScannerCopyResultsWithOptions(scanner.get(), DDScannerCopyResultsOptionsNoOverlap));
> +
> +
> +    CFIndex resultCount = CFArrayGetCount(results.get());

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:175
> +        // How does ownership work here?

?

Comment 6 Tim Horton 2014-12-08 11:40:09 PST

https://trac.webkit.org/changeset/176959

Comment 7 Radar WebKit Bug Importer 2014-12-08 11:41:26 PST

<rdar://problem/19179009>