Bug 139133

Summary: Subtitle menu should only appear when useful.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jeremy Jones
Reported 2014-12-01 09:53:57 PST
Subtitle menu should only appear when useful.
Attachments
Patch (1.50 KB, patch)
2014-12-01 09:56 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2014-12-01 12:46 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2014-12-01 09:54:47 PST
rdar://problem/17280893
Jeremy Jones
Comment 2 2014-12-01 09:56:28 PST
Created attachment 242319 [details] Patch
Jon Lee
Comment 3 2014-12-01 09:58:10 PST
Comment on attachment 242319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242319&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:399 > + return [[self legibleMediaSelectionOptions] count] > numDefaultLegibleOptions; Does this also take into account audio tracks?
Jeremy Jones
Comment 4 2014-12-01 12:20:11 PST
(In reply to comment #3) > Comment on attachment 242319 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242319&action=review > > > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:399 > > + return [[self legibleMediaSelectionOptions] count] > numDefaultLegibleOptions; > > Does this also take into account audio tracks? Audio tracks are not currently implemented. Bug: 131236 I can update this change to anticipate that implementation. - return [[self audioMediaSelectionOptions] count] > 0; + return [[self audioMediaSelectionOptions] count] > 1;
Eric Carlson
Comment 5 2014-12-01 12:36:13 PST
Comment on attachment 242319 [details] Patch r=me with the change noted.
Jeremy Jones
Comment 6 2014-12-01 12:46:47 PST
Created attachment 242331 [details] Patch
WebKit Commit Bot
Comment 7 2014-12-03 12:02:44 PST
Comment on attachment 242331 [details] Patch Clearing flags on attachment: 242331 Committed r176734: <http://trac.webkit.org/changeset/176734>
WebKit Commit Bot
Comment 8 2014-12-03 12:02:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.