Bug 139133

Summary: Subtitle menu should only appear when useful.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jeremy Jones 2014-12-01 09:53:57 PST 
Subtitle menu should only appear when useful.
Comment 1 Jeremy Jones 2014-12-01 09:54:47 PST 
rdar://problem/17280893
Comment 2 Jeremy Jones 2014-12-01 09:56:28 PST 
Created attachment 242319 [details]
Patch
Comment 3 Jon Lee 2014-12-01 09:58:10 PST 
Comment on attachment 242319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242319&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:399
> +    return [[self legibleMediaSelectionOptions] count] > numDefaultLegibleOptions;

Does this also take into account audio tracks?
Comment 4 Jeremy Jones 2014-12-01 12:20:11 PST 
(In reply to comment #3)
> Comment on attachment 242319 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242319&action=review
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:399
> > +    return [[self legibleMediaSelectionOptions] count] > numDefaultLegibleOptions;
> 
> Does this also take into account audio tracks?

Audio tracks are not currently implemented. Bug: 131236

I can update this change to anticipate that implementation. 

-     return [[self audioMediaSelectionOptions] count] > 0;
+     return [[self audioMediaSelectionOptions] count] > 1;
Comment 5 Eric Carlson 2014-12-01 12:36:13 PST 
Comment on attachment 242319 [details]
Patch

r=me with the change noted.
Comment 6 Jeremy Jones 2014-12-01 12:46:47 PST 
Created attachment 242331 [details]
Patch
Comment 7 WebKit Commit Bot 2014-12-03 12:02:44 PST 
Comment on attachment 242331 [details]
Patch

Clearing flags on attachment: 242331

Committed r176734: <http://trac.webkit.org/changeset/176734>
Comment 8 WebKit Commit Bot 2014-12-03 12:02:50 PST 
All reviewed patches have been landed.  Closing bug.