| Summary: | Fix class was previously declared as a struct warnings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Éva Balázsfalvi <evab.u-szeged> | ||||
| Component: | Tools / Tests | Assignee: | Éva Balázsfalvi <evab.u-szeged> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | clopez, commit-queue, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 242313 [details]
Patch
Comment on attachment 242313 [details] Patch Clearing flags on attachment: 242313 Committed r176632: <http://trac.webkit.org/changeset/176632> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > Comment on attachment 242313 [details] > Patch > > Clearing flags on attachment: 242313 > > Committed r176632: <http://trac.webkit.org/changeset/176632> This made the ChangeLog files executables :\ diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog old mode 100644 new mode 100755 diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog old mode 100644 new mode 100755 (In reply to comment #4) > (In reply to comment #2) > > Comment on attachment 242313 [details] > > Patch > > > > Clearing flags on attachment: 242313 > > > > Committed r176632: <http://trac.webkit.org/changeset/176632> > > > This made the ChangeLog files executables :\ > > > diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog > old mode 100644 > new mode 100755 > > > diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog > old mode 100644 > new mode 100755 OMG :-/ Style checker should have warn about it. :( Thanks for noticing it, let us fix it quickly. |
warnings: ../../Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:56:1: warning: 'TextureMapperGLData' defined as a struct here but previously declared as a class [-Wmismatched-tags] struct TextureMapperGLData { ^ ../../Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:34:1: note: did you mean struct here? class TextureMapperGLData; ^~~~~ struct 1 warning generated. ../../Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:32:1: warning: class 'CoordinatedGraphicsState' was previously declared as a struct [-Wmismatched-tags] class CoordinatedGraphicsState; ^ ../../Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:175:8: note: previous use is here struct CoordinatedGraphicsState { ^ ../../Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:32:1: note: did you mean struct here? class CoordinatedGraphicsState; ^~~~~ struct 1 warning generated. ../../Source/WebKit2/UIProcess/CoordinatedGraphics/WebViewClient.h:39:1: warning: class 'ViewportAttributes' was previously declared as a struct [-Wmismatched-tags] class ViewportAttributes; ^ ../../Source/WebCore/dom/ViewportArguments.h:45:8: note: previous use is here struct ViewportAttributes { ^ ../../Source/WebKit2/UIProcess/CoordinatedGraphics/WebViewClient.h:39:1: note: did you mean struct here? class ViewportAttributes; ^~~~~ struct 1 warning generated. --- TextureMapperGLData, CoordinatedGraphicsState and ViewportAttributes are structs, the noticed forward declarations incorrect, we should use struct instead of class.