Bug 139086

Summary:

[EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2014-11-28 02:07:46 PST

[EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules

Comment 1 Csaba Osztrogonác 2014-11-28 02:08:04 PST

Created attachment 242263 [details]
Patch

Comment 2 Csaba Osztrogonác 2014-11-28 02:25:09 PST

To build with clang instead of gcc, we usually set CC=clang, CXX=clang++ 
and ICECC_VERSION=clang-toolchain.tar.gz.

Unfortunately libseccomp doesn't respect CC environment variable and
calling gcc (/usr/lib/icecc/bin/gcc) when ICECC_VERSION points to a
clang toolchain causes strange error messages.

I think the proper fix is to pick up CC as other jhbuild modules already do.

Comment 3 Gyuyoung Kim 2014-11-28 04:26:59 PST

Comment on attachment 242263 [details]
Patch

rs=me.

Comment 4 WebKit Commit Bot 2014-11-28 05:41:29 PST

Comment on attachment 242263 [details]
Patch

Clearing flags on attachment: 242263

Committed r176562: <http://trac.webkit.org/changeset/176562>

Comment 5 WebKit Commit Bot 2014-11-28 05:41:32 PST

All reviewed patches have been landed.  Closing bug.