Bug 139079 – Fix -Wc++11-narrowing error in SeccompFilters.cpp

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:71:83: error: non-constant-expression cannot be narrowed from type 'long long' to 'scmp_datum_t' (aka 'unsigned long') in initializer list [-Wc++11-narrowing]
            ((struct scmp_arg_cmp){argNum1, static_cast<scmp_compare>(operator1), data1, 0}),
                                                                                  ^~~~~
../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:71:83: note: override this message by inserting an explicit cast
            ((struct scmp_arg_cmp){argNum1, static_cast<scmp_compare>(operator1), data1, 0}),
                                                                                  ^~~~~
                                                                                  static_cast<scmp_datum_t>( )
../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:72:83: error: non-constant-expression cannot be narrowed from type 'long long' to 'scmp_datum_t' (aka 'unsigned long') in initializer list [-Wc++11-narrowing]
            ((struct scmp_arg_cmp){argNum2, static_cast<scmp_compare>(operator2), data2, 0}));
                                                                                  ^~~~~
../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:72:83: note: override this message by inserting an explicit cast
            ((struct scmp_arg_cmp){argNum2, static_cast<scmp_compare>(operator2), data2, 0}));
                                                                                  ^~~~~
                                                                                  static_cast<scmp_datum_t>( )
../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:75:83: error: non-constant-expression cannot be narrowed from type 'long long' to 'scmp_datum_t' (aka 'unsigned long') in initializer list [-Wc++11-narrowing]
            ((struct scmp_arg_cmp){argNum1, static_cast<scmp_compare>(operator1), data1, 0}));
                                                                                  ^~~~~
../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:75:83: note: override this message by inserting an explicit cast
            ((struct scmp_arg_cmp){argNum1, static_cast<scmp_compare>(operator1), data1, 0}));
                                                                                  ^~~~~
                                                                                  static_cast<scmp_datum_t>( )
3 errors generated.

[Csaba Osztrogonác]

seccomp.h:
-----------
/**
 * Argument datum
 */
typedef uint64_t scmp_datum_t;



scmp_datum_t is uint64_t, we should use uint64_t instead of long long to fix the build.

[Csaba Osztrogonác]

Created attachment 242256 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 242256 [details]
Patch

Clearing flags on attachment: 242256

Committed r176558: <http://trac.webkit.org/changeset/176558>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.