Bug 139064

Summary:

[GStreamer] HTTP source element lacks SCHEDULING query support

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	cgarcia: review+

Philippe Normand

Reported 2014-11-26 07:20:53 PST

This is needed for adaptive streaming cases.

Attachments
patch (2.25 KB, patch) 2014-11-26 07:25 PST, Philippe Normand	cgarcia: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2014-11-26 07:25:20 PST

Created attachment 242229 [details] patch

Carlos Garcia Campos

Comment 2 2014-11-26 08:06:05 PST

Comment on attachment 242229 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=242229&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:589 > + gint minSize, maxSize, align; Nit: use int instead of gint here. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:592 > + flags = static_cast<GstSchedulingFlags>(static_cast<unsigned>(flags) | GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED); Do you really need the unsigned cast too? can't this be flags |= GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED?

Philippe Normand

Comment 3 2014-11-26 08:35:37 PST

(In reply to comment #2) > Comment on attachment 242229 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242229&action=review > > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:589 > > + gint minSize, maxSize, align; > > Nit: use int instead of gint here. > ok :) > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:592 > > + flags = static_cast<GstSchedulingFlags>(static_cast<unsigned>(flags) | GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED); > > Do you really need the unsigned cast too? can't this be flags |= > GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED? Fails to build here: ../../Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In function ‘gboolean webKitWebSrcQueryWithParent(GstPad*, GstObject*, GstQuery*)’: ../../Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:593:15: error: invalid conversion from ‘int’ to ‘GstSchedulingFlags’ [-fpermissive] flags |= GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED;

Philippe Normand

Comment 4 2014-11-26 08:57:03 PST

Ah well, not using a variable and doing a static_cast works. I think I'll land this tomorrow!

Philippe Normand

Comment 5 2014-11-28 03:05:08 PST

Committed r176561: <http://trac.webkit.org/changeset/176561>

Note You need to log in before you can comment on or make changes to this bug.