Summary: | [CSS Grid Layout] Tracks shrink sometimes with indefinite remaining space | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, darin, dino, esprehn+autocc, glenn, jfernandez, kling, koivisto, kondapallykalyan, ossy, rego | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 140546 | ||||||
Bug Blocks: | 60731, 139058 | ||||||
Attachments: |
|
Description
Sergio Villar Senin
2014-11-26 04:10:34 PST
Created attachment 242224 [details]
Patch
ping reviewers... Comment on attachment 242224 [details]
Patch
r=me
Committed r178577: <http://trac.webkit.org/changeset/178577> (In reply to comment #4) > Committed r178577: <http://trac.webkit.org/changeset/178577> It made fast/css-grid-layout/grid-content-sized-columns-resolution.html fail. -PASS window.getComputedStyle(gridAutoAndFixedFixedAndMaxContentFixed, '').getPropertyValue('-webkit-grid-template-columns') is "70px 20px 60px" +FAIL window.getComputedStyle(gridAutoAndFixedFixedAndMaxContentFixed, '').getPropertyValue('-webkit-grid-template-columns') should be 70px 20px 60px. Was 40px 20px 90px. Will roll out. Re-opened since this is blocked by bug 140546 Committed r178642: <http://trac.webkit.org/changeset/178642> (In reply to comment #6) > -PASS window.getComputedStyle(gridAutoAndFixedFixedAndMaxContentFixed, > '').getPropertyValue('-webkit-grid-template-columns') is "70px 20px 60px" > +FAIL window.getComputedStyle(gridAutoAndFixedFixedAndMaxContentFixed, > '').getPropertyValue('-webkit-grid-template-columns') should be 70px 20px > 60px. Was 40px 20px 90px. > > Will roll out. Thanks for taking care of this. I somehow committed a different patch than the one I had previously uploaded for review, perhaps I messed up something while rebasing. |