Bug 139055

Summary:

[EFL] Add warning if CMake version is too old for building with ninja.

Product:

WebKit

Reporter:

Bartlomiej Gajda <b.gajda>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Bartlomiej Gajda

Reported 2014-11-26 00:51:55 PST

CMake 2.8.9 does not know CMAKE_NINJA_FORCE_RESPONSE_FILE, so it won't allow You to build WebKit using ninja. On Ubuntu 12.04 (which many people still use as it was previous LTS) doing 'apt-get install cmake' You do get 2.8.9. Apparently same situation occurs in 12.10 ( https://lists.webkit.org/pipermail/webkit-gtk/2014-March/001809.html ) I thought we might add small warning (and for 12.04 proposed solution), if such old version will be detected to inform developer at time, to save him searching. Opinions?

Attachments
proposed patch (2.04 KB, patch) 2014-11-26 00:53 PST, Bartlomiej Gajda	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Bartlomiej Gajda

Comment 1 2014-11-26 00:53:38 PST

Created attachment 242220 [details] proposed patch

Gyuyoung Kim

Comment 2 2014-11-27 18:02:14 PST

Comment on attachment 242220 [details] proposed patch LGTM.

WebKit Commit Bot

Comment 3 2014-11-28 01:49:58 PST

Comment on attachment 242220 [details] proposed patch Clearing flags on attachment: 242220 Committed r176560: <http://trac.webkit.org/changeset/176560>

WebKit Commit Bot

Comment 4 2014-11-28 01:50:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.