Bug 139040

Summary:

[MSE] Rename highest presentation end timestamp to group end timestamp, per spec

Product:

WebKit

Reporter:

Bartlomiej Gajda <b.gajda>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

calvaris, commit-queue, eric.carlson, glenn, jer.noble, ltilve, philipj, sam, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch v1	none

Description Bartlomiej Gajda 2014-11-25 03:05:46 PST

According to http://www.w3.org/TR/media-source/#revision-history
01 April 2014 : "Bug 24820 - Renamed highest presentation end timestamp to group end timestamp and fixed a few related issues."

This does the rename part.

Comment 1 Bartlomiej Gajda 2014-11-25 03:12:17 PST

Created attachment 242193 [details]
patch v1

Comment 2 Bartlomiej Gajda 2014-11-25 03:24:32 PST

Also according to spec Group End Timestamp should be intialized to 0, not to invalid time as it is now. 

Before 01.04.2014 revision there was line:

"If highest presentation end timestamp is unset or frame end timestamp is greater than highest presentation ..."

but now it's:

"If frame end timestamp is greater than group end timestamp, then set group end timestmap..."

Shall I add this to this change, or make another bug for it?

Comment 3 Sam Weinig 2014-11-28 23:10:48 PST

(In reply to comment #2)
> Also according to spec Group End Timestamp should be intialized to 0, not to
> invalid time as it is now. 
> 
> Before 01.04.2014 revision there was line:
> 
> "If highest presentation end timestamp is unset or frame end timestamp is
> greater than highest presentation ..."
> 
> but now it's:
> 
> "If frame end timestamp is greater than group end timestamp, then set group
> end timestmap..."
> 
> Shall I add this to this change, or make another bug for it?

You could do all that in one change, but you would need a test case if you change behavior.

Comment 4 Bartlomiej Gajda 2014-12-09 02:25:07 PST


*** This bug has been marked as a duplicate of bug 139265 ***