Bug 139029
| Summary: | background-size should not accept unitless lengths | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Pieters (:zcorpan) <zcorpan> |
| Component: | CSS | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, benjamin, bfulgham, cdumez, gsnedders, koivisto, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Pieters (:zcorpan)
We should limit the hashless hex color and unitless length quirks to the set of properties listed in the quirks spec:
https://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk
https://quirks.spec.whatwg.org/#the-unitless-length-quirk
Why: https://quirks.spec.whatwg.org/#goals
Gecko fixed this in 2012 https://bugzilla.mozilla.org/show_bug.cgi?id=774122
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
This is:
https://wpt.fyi/results/quirks/unitless-length?label=master&label=experimental&aligned
(and the currently-all-passing
https://wpt.fyi/results/quirks/hashless-hex-color?label=experimental&label=master&aligned)
Radar WebKit Bug Importer
<rdar://problem/97039770>
Ahmad Saleem
Safari Technology Preview 154 is still failing one case:
http://wpt.live/quirks/unitless-length/excluded-properties-002.html
> Property background-size does not support quirky length
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/12644
EWS
Committed 262873@main (0b6c4aa962f5): <https://commits.webkit.org/262873@main>
Reviewed commits have been landed. Closing PR #12644 and removing active labels.