Bug 139023

Summary:

[GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, commit-queue, gustavo, mrobinson, pnormand, svillar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	svillar: review+

Description Carlos Garcia Campos 2014-11-24 02:58:45 PST

The WebKitWebContext is a construct only property, so it's always set to the default value when not provided, during the construction. When a related-view is used to create a new web view we should ensure that the same web context is used for the new web view, instead of the default. We should also ignore any web context given as construct parameter if a related view is alos provided.

Comment 1 Carlos Garcia Campos 2014-11-24 03:03:01 PST

Created attachment 242154 [details]
Patch

Comment 2 WebKit Commit Bot 2014-11-24 03:05:49 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Sergio Villar Senin 2014-11-24 03:13:11 PST

Comment on attachment 242154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242154&action=review

> Source/WebKit2/ChangeLog:13
> +        context given as construct parameter if a related view is alos provided.

Nit: alos->also

Comment 4 Carlos Garcia Campos 2014-11-24 03:18:46 PST

Committed r176513: <http://trac.webkit.org/changeset/176513>