Bug 139018

Summary:

Use std::unique_ptr<> and std::make_unique<> in JSC

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

JavaScriptCore

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

buildbot, darin, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128007

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none

Gyuyoung Kim

Reported 2014-11-23 18:16:16 PST

SSIA

Attachments
Patch (12.55 KB, patch) 2014-11-23 18:17 PST, Gyuyoung Kim	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (288.94 KB, application/zip) 2014-11-23 19:55 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (55.16 KB, application/zip) 2014-11-23 20:25 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (66.09 KB, application/zip) 2014-11-23 22:25 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2014-11-23 18:17:27 PST

Created attachment 242138 [details] Patch

Build Bot

Comment 2 2014-11-23 19:55:29 PST

Comment on attachment 242138 [details] Patch Attachment 242138 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5338118307708928 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2014-11-23 19:55:32 PST

Created attachment 242139 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-11-23 20:25:56 PST

Comment on attachment 242138 [details] Patch Attachment 242138 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4858520583274496 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2014-11-23 20:25:58 PST

Created attachment 242140 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-11-23 22:25:48 PST

Comment on attachment 242138 [details] Patch Attachment 242138 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6474990580924416 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2014-11-23 22:25:51 PST

Created attachment 242145 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Darin Adler

Comment 8 2015-04-19 22:17:59 PDT

Most everything here was already dealt with. Marking this as a duplicate of a patch where I do the last few fixes to get JavaScriptCore 100% clean of these classes. *** This bug has been marked as a duplicate of bug 143941 ***

Note You need to log in before you can comment on or make changes to this bug.