Bug 138997 – Web Inspector: add more :not() and :matches() awesomeness

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin Poulain]

Web Inspector: add more :not() and :matches() awesomeness

[Benjamin Poulain]

Created attachment 242106 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 242106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242106&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css:102
> -body.mac-platform.legacy .toolbar .dashboard,
> -body.mac-platform.legacy.window-inactive .toolbar .dashboard {
> +body.mac-platform.legacy .toolbar .dashboard {

Hmm. Though yes this is true, we may want to keep both here so that we don't accidentally have the non-legacy .window-inactive styles later get more specificity and trigger on legacy. Also, it provides clarity that this style should be used in both the active and inactive cases for legacy.

> Source/WebInspectorUI/UserInterface/Views/RadioButtonNavigationItem.css:70
> -body.mac-platform.legacy .navigation-bar .item.radio.button.text-only:active,
> -body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected:active {
> +body.mac-platform.legacy .navigation-bar .item.radio.button.text-only:active {

Ditto.

> Source/WebInspectorUI/UserInterface/Views/SyntaxHighlightingDefaultTheme.css:43
> +.cm-s-default :matches(.cm-tag, .cm-bracket, .cm-atom, .cm-keyword, .cm-m-javascript.cm-builtin),
> +.cm-s-default .cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-3, .cm-property),
> +.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag) {

Seem this is missing a selector:

    .cm-s-default .cm-m-javascript.cm-builtin,

> Source/WebInspectorUI/UserInterface/Views/SyntaxHighlightingDefaultTheme.css:52
> +.cm-s-default :matches(.cm-def, .cm-operator, .cm-variable, .cm-variable-2),

This is missing ".cm-bracket" in the list.

[Benjamin Poulain]

Committed r176610: <http://trac.webkit.org/changeset/176610>