Summary: | Web Inspector: timeline probe records have inaccurate per-probe hit counts | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||||||||
Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, graouts, joepeck, madonnk, rniwa, timothy, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 132073 | ||||||||||||||
Attachments: |
|
Description
Brian Burg
2014-11-21 12:12:37 PST
I have a patch forthcoming to fix the backend parts. madonk will write a test to be written to cover sampleId behavior. In particular, the samples obtained from the timeline record should match what is seen in the probe manager. Created attachment 242094 [details]
Patch
Created attachment 242428 [details]
Proposed Patch
Created attachment 242436 [details]
Proposed Fix
Comment on attachment 242436 [details] Proposed Fix Attachment 242436 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5347395973939200 New failing tests: transitions/default-timing-function.html Created attachment 242452 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 242498 [details]
Proposed Fix (fixed ChangeLog)
Comment on attachment 242498 [details] Proposed Fix (fixed ChangeLog) View in context: https://bugs.webkit.org/attachment.cgi?id=242498&action=review r=me > LayoutTests/inspector-protocol/debugger/didSampleProbe-multiple-probes.html:42 > + return samples.every(function(sample, idx) { return sample.sampleId = idx + 1; }); I think the every predicate callback should be: return sample.sampleId === idx + 1; Otherwise it will always be returning true! (In reply to comment #9) > Comment on attachment 242498 [details] > Proposed Fix (fixed ChangeLog) > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242498&action=review > > r=me > > > LayoutTests/inspector-protocol/debugger/didSampleProbe-multiple-probes.html:42 > > + return samples.every(function(sample, idx) { return sample.sampleId = idx + 1; }); > > I think the every predicate callback should be: > > return sample.sampleId === idx + 1; > > Otherwise it will always be returning true! Doh, will fix before landing. Committed r176817: <http://trac.webkit.org/changeset/176817> This test fails when run multiple times, the sample ids seem to increase (5-8) instead of (1-4). shell> run-webkit-tests inspector-protocol/debugger/didSampleProbe-multiple-probes.html --repeat-each 2 -v --no-retry -g --additional-env-var="JSC_slowPathAllocsBetweenGCs=1" |