Bug 138956

Summary: Implement yellow highlight for WebKit1 data detectors
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, dino, mitz, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch bdakin: review+

Tim Horton
Reported 2014-11-21 03:00:00 PST
Implement yellow highlight for WebKit1 data detectors
Attachments
Patch (11.36 KB, patch)
2014-11-21 03:00 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (27.26 KB, patch)
2014-11-22 00:05 PST, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-21 03:00:28 PST
Created attachment 242033 [details] Patch
Tim Horton
Comment 2 2014-11-21 03:01:15 PST
This depends on https://bugs.webkit.org/show_bug.cgi?id=138954 so it will not build.
WebKit Commit Bot
Comment 3 2014-11-21 03:03:19 PST
Attachment 242033 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebView.mm:8567: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebView/WebViewInternal.h:259: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2014-11-21 12:31:50 PST
This needs some adjustments just like https://bugs.webkit.org/show_bug.cgi?id=138955
Tim Horton
Comment 5 2014-11-22 00:05:59 PST
Created attachment 242115 [details] Patch
Tim Horton
Comment 6 2014-11-22 00:06:19 PST
<rdar://problem/18992185>
WebKit Commit Bot
Comment 7 2014-11-22 00:07:38 PST
Attachment 242115 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebView.mm:8569: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebView/WebViewInternal.h:260: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 8 2014-12-01 12:48:21 PST
http://trac.webkit.org/changeset/176599
Tim Horton
Comment 9 2014-12-01 15:56:32 PST
iOS build fixes in http://trac.webkit.org/changeset/176608
Tim Horton
Comment 10 2014-12-01 17:50:54 PST
Mac build fixes in http://trac.webkit.org/changeset/176618
Note You need to log in before you can comment on or make changes to this bug.