| Summary: | Implement yellow highlight for WebKit1 data detectors | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, bdakin, commit-queue, dino, mitz, sam, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2014-11-21 03:00:00 PST
Created attachment 242033 [details]
Patch
This depends on https://bugs.webkit.org/show_bug.cgi?id=138954 so it will not build. Attachment 242033 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebView.mm:8567: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/mac/WebView/WebViewInternal.h:259: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This needs some adjustments just like https://bugs.webkit.org/show_bug.cgi?id=138955 Created attachment 242115 [details]
Patch
Attachment 242115 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebView.mm:8569: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/mac/WebView/WebViewInternal.h:260: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
iOS build fixes in http://trac.webkit.org/changeset/176608 Mac build fixes in http://trac.webkit.org/changeset/176618 |