Bug 138953

Summary:

Refcount the render tree.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

NEW ---

Severity:

Normal

CC:

buildbot, commit-queue, fred.wang, koivisto, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
WIP II	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none

Description Andreas Kling 2014-11-21 01:46:29 PST

We should try refcounting the render tree and see how that feels (and performs, mostly.)

Comment 1 Andreas Kling 2014-11-21 01:47:41 PST

Created attachment 242030 [details]
WIP

This is a bit hairy, but it's getting there.

Comment 2 WebKit Commit Bot 2014-11-21 01:49:44 PST

Attachment 242030 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderTableSection.h:74:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGInline.h:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRubyRun.cpp:114:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGContainer.h:51:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTableRow.cpp:110:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:262:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:301:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:510:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTable.h:130:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:40:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:125:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:126:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGText.h:86:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:103:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGText.cpp:534:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderMenuList.h:68:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLToken.h:45:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGRoot.cpp:307:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGRoot.h:82:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:90:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLMenclose.h:42:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTable.cpp:138:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderElement.cpp:470:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRuby.h:59:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRuby.h:79:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:343:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:406:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:414:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:757:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:757:  hackGuard_FIXME is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/rendering/RenderBlockFlow.h:379:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:139:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderMenuList.cpp:175:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:47:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGInline.cpp:123:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLFenced.h:45:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3698:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLFraction.h:48:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.h:45:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.h:75:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTableRow.h:91:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderButton.cpp:65:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTableSection.cpp:137:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.h:77:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.h:414:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.h:415:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGContainer.cpp:90:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRuby.cpp:137:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRuby.cpp:243:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:226:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:457:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLRoot.h:48:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderButton.h:45:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRubyRun.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderElement.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderElement.h:86:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:51:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 57 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Build Bot 2014-11-21 03:20:38 PST

Comment on attachment 242030 [details]
WIP

Attachment 242030 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5748187625160704

Number of test failures exceeded the failure limit.

Comment 4 Build Bot 2014-11-21 03:20:41 PST

Created attachment 242034 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 5 Build Bot 2014-11-21 03:55:13 PST

Comment on attachment 242030 [details]
WIP

Attachment 242030 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6165726092066816

Number of test failures exceeded the failure limit.

Comment 6 Build Bot 2014-11-21 03:55:16 PST

Created attachment 242037 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 7 Build Bot 2014-11-21 06:00:29 PST

Comment on attachment 242030 [details]
WIP

Attachment 242030 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5859342452523008

Number of test failures exceeded the failure limit.

Comment 8 Build Bot 2014-11-21 06:00:33 PST

Created attachment 242043 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 9 Andreas Kling 2014-11-21 11:17:44 PST

Created attachment 242054 [details]
WIP II

Comment 10 WebKit Commit Bot 2014-11-21 11:20:27 PST

Attachment 242054 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderTableSection.h:74:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGInline.h:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRubyRun.cpp:114:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGContainer.h:51:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTableRow.cpp:110:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:262:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:301:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:343:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:434:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:434:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:434:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:498:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTable.h:130:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:40:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:125:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:126:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:128:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:130:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:130:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderInline.h:130:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGText.h:86:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:103:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGText.cpp:534:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderMenuList.h:68:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLToken.h:45:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGRoot.cpp:307:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGRoot.h:82:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:90:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLMenclose.h:42:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTable.cpp:138:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderElement.cpp:470:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderElement.cpp:535:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRuby.h:59:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRuby.h:79:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:343:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:406:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:414:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlockFlow.h:379:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:142:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderMenuList.cpp:175:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:47:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGInline.cpp:123:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLFenced.h:45:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3698:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLFraction.h:48:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.h:45:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.h:57:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.h:75:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTableRow.h:91:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderButton.cpp:65:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderTableSection.cpp:137:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.h:77:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.h:414:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderBlock.h:415:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/svg/RenderSVGContainer.cpp:90:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRuby.cpp:137:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRuby.cpp:243:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:144:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:226:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:377:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:457:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLRoot.h:48:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderButton.h:45:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderRubyRun.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderElement.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderElement.h:86:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/RenderElement.h:98:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:51:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 69 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Build Bot 2014-11-21 12:45:40 PST

Comment on attachment 242054 [details]
WIP II

Attachment 242054 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4904471565959168

Number of test failures exceeded the failure limit.

Comment 12 Build Bot 2014-11-21 12:45:43 PST

Created attachment 242064 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 13 Build Bot 2014-11-21 13:27:44 PST

Comment on attachment 242054 [details]
WIP II

Attachment 242054 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5853080390205440

Number of test failures exceeded the failure limit.

Comment 14 Build Bot 2014-11-21 13:27:48 PST

Created attachment 242066 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 15 Frédéric Wang (:fredw) 2016-06-28 00:11:21 PDT

What is the status of this? After https://trac.webkit.org/wiki/MathML/Early_2016_Refactoring#Phase1 most of the changes tried for MathML seems unnecessary now (except for the mfenced element which is the only one continuing to deal with anonymous nodes).

Comment 16 Antti Koivisto 2016-06-28 16:16:28 PDT

I think we abandoned this plan for now.