Bug 138950

Summary: [EFL] Use a variable to set flicking time instead of hardcoding
Product: WebKit Reporter: Sanghyup Lee <sh53.lee>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Sanghyup Lee 2014-11-20 21:59:18 PST
Currently time of flick gesture animation is hardcoded as one second.
This patch added a variable for it to increase readability.
Comment 1 Sanghyup Lee 2014-11-20 22:01:24 PST
Created attachment 242023 [details]
Patch
Comment 2 Ryuan Choi 2014-11-20 23:58:09 PST
Comment on attachment 242023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242023&action=review

> Source/WebKit2/ChangeLog:9
> +        Currently time of flick gesture animation is hardcoded as one second.
> +        This patch added a variable for it to increase readability.

Then, why you should add it to normal member variable instead of static variable?
Comment 3 Sanghyup Lee 2014-11-21 00:38:32 PST
(In reply to comment #2)
> Comment on attachment 242023 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242023&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Currently time of flick gesture animation is hardcoded as one second.
> > +        This patch added a variable for it to increase readability.
> 
> Then, why you should add it to normal member variable instead of static
> variable?

It's my mistake. I'll fix it.
Comment 4 Sanghyup Lee 2014-11-21 01:25:36 PST
Created attachment 242028 [details]
Patch
Comment 5 Sanghyup Lee 2014-11-21 01:31:28 PST
Created attachment 242029 [details]
Patch
Comment 6 Ryuan Choi 2015-02-08 20:55:20 PST
Comment on attachment 242029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242029&action=review

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:236
> +    float multiplier = easeInOutQuad(gestureHandler->m_flickIndex, 0, gestureHandler->s_flickTime, gestureHandler->m_flickDuration);

gestureHandler looks not needed anymore.
Comment 7 Sanghyup Lee 2015-02-08 22:20:53 PST
Created attachment 246257 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2015-02-10 00:24:56 PST
Comment on attachment 246257 [details]
Patch for landing

Clearing flags on attachment: 246257

Committed r179867: <http://trac.webkit.org/changeset/179867>
Comment 9 WebKit Commit Bot 2015-02-10 00:25:00 PST
All reviewed patches have been landed.  Closing bug.