Summary: | [EFL] Use a variable to set flicking time instead of hardcoding | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sanghyup Lee <sh53.lee> | ||||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, lucas.de.marchi | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sanghyup Lee
2014-11-20 21:59:18 PST
Created attachment 242023 [details]
Patch
Comment on attachment 242023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242023&action=review > Source/WebKit2/ChangeLog:9 > + Currently time of flick gesture animation is hardcoded as one second. > + This patch added a variable for it to increase readability. Then, why you should add it to normal member variable instead of static variable? (In reply to comment #2) > Comment on attachment 242023 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242023&action=review > > > Source/WebKit2/ChangeLog:9 > > + Currently time of flick gesture animation is hardcoded as one second. > > + This patch added a variable for it to increase readability. > > Then, why you should add it to normal member variable instead of static > variable? It's my mistake. I'll fix it. Created attachment 242028 [details]
Patch
Created attachment 242029 [details]
Patch
Comment on attachment 242029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242029&action=review > Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:236 > + float multiplier = easeInOutQuad(gestureHandler->m_flickIndex, 0, gestureHandler->s_flickTime, gestureHandler->m_flickDuration); gestureHandler looks not needed anymore. Created attachment 246257 [details]
Patch for landing
Comment on attachment 246257 [details] Patch for landing Clearing flags on attachment: 246257 Committed r179867: <http://trac.webkit.org/changeset/179867> All reviewed patches have been landed. Closing bug. |