Bug 138936 – Two WebGL tests try to use an external resource

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

http//tests/webgl/1.0.2/texImage2DHTML.html
http//tests/webgl/1.0.2/texSubImage2DHTML.html

These tests try to load http://mashable.com/wp-content/uploads/2008/08/thunderbird-logo-64x64.png, which is not allowed in layout tests.

I'm not sure what exactly the consequence is, except for that it causes tests to fail when run in a different order (due to WebCore cache). Do these test not test what they are supposed to test, as a result? Do they need to test cross-origin? Can we copy this image into the repository, or would that be a license violation?

[Dean Jackson]

Wow. I didn't realise this. We should use another 64x64 image, or make one.

[Dean Jackson]

Oh, they are cross origin tests.

[Roger Fong]

Created attachment 242000 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 242000 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242000&action=review

> LayoutTests/ChangeLog:8
> +        * http/tests/resources/square128.png: Added.

This should change expected results, I think.

[Build Bot]

Comment on attachment 242000 [details]
patch

Attachment 242000 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5797666923479040

New failing tests:
http/tests/webgl/1.0.2/texSubImage2DHTML.html
http/tests/webgl/1.0.2/texImage2DHTML.html

[Build Bot]

Created attachment 242007 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 242000 [details]
patch

Attachment 242000 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6508589036339200

New failing tests:
http/tests/webgl/1.0.2/texSubImage2DHTML.html
http/tests/webgl/1.0.2/texImage2DHTML.html

[Build Bot]

Created attachment 242010 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Roger Fong]

Created attachment 242016 [details]
patch

Layout test results taken from EWS bots.

[Roger Fong]

(In reply to comment #9)
> Created attachment 242016 [details]
> patch
> 
> Layout test results taken from EWS bots.

So that all the white spaces match up...the actual content of the results from the EWS bots are also correct...in case anyone was wondering.

[WebKit Commit Bot]

Comment on attachment 242016 [details]
patch

Rejecting attachment 242016 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 242016, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
exImage2DHTML.html.rej
patching file LayoutTests/http/tests/webgl/1.0.2/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html
Hunk #1 FAILED at 159.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/tests/webgl/1.0.2/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5091635503300608

[Alexey Proskuryakov]

Roger committed manually in <http://trac.webkit.org/changeset/176456>.