Bug 138934

Summary:

Add some comments to describe the DFG UseKind representations.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, mmirman, msaboff

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	none
patch 2: addressed Geoff's feedback.	fpizlo: review-
patch 3: UntypedUse is at enum 0 again, with extra comments.	none
patch 4: don't like the comment about UntypedUse in last patch. Updated.	fpizlo: review+
patch 5: moved al the JSValue representation UseKinds up nelow UntypedUse as Filip suggested.	fpizlo: review+

Mark Lam

Reported 2014-11-20 14:09:54 PST

Also regrouped the UseKind enums by representation.

Attachments
the patch. (1.85 KB, patch) 2014-11-20 14:12 PST, Mark Lam	no flags	Details Formatted Diff Diff
patch 2: addressed Geoff's feedback. (1.85 KB, patch) 2014-11-20 15:16 PST, Mark Lam	fpizlo: review-	Details Formatted Diff Diff
patch 3: UntypedUse is at enum 0 again, with extra comments. (2.14 KB, patch) 2014-11-20 15:23 PST, Mark Lam	no flags	Details Formatted Diff Diff
patch 4: don't like the comment about UntypedUse in last patch. Updated. (2.14 KB, patch) 2014-11-20 15:31 PST, Mark Lam	fpizlo: review+	Details Formatted Diff Diff
patch 5: moved al the JSValue representation UseKinds up nelow UntypedUse as Filip suggested. (2.11 KB, patch) 2014-11-20 15:36 PST, Mark Lam	fpizlo: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2014-11-20 14:12:55 PST

Created attachment 241980 [details] the patch.

Geoffrey Garen

Comment 2 2014-11-20 15:13:43 PST

Comment on attachment 241980 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=241980&action=review > Source/JavaScriptCore/dfg/DFGUseKind.h:38 > UntypedUse, Which case is UntypedUse? (Seems like it should be JSValue, right?) > Source/JavaScriptCore/dfg/DFGUseKind.h:43 > + // in a FP register. "an"

Mark Lam

Comment 3 2014-11-20 15:16:11 PST

Created attachment 241989 [details] patch 2: addressed Geoff's feedback.

Filip Pizlo

Comment 4 2014-11-20 15:17:53 PST

Comment on attachment 241989 [details] patch 2: addressed Geoff's feedback. View in context: https://bugs.webkit.org/attachment.cgi?id=241989&action=review > Source/JavaScriptCore/dfg/DFGUseKind.h:54 > UntypedUse, This could be dangerous; I believe that UntypedUse is expected to be zero.

Filip Pizlo

Comment 5 2014-11-20 15:18:17 PST

Comment on attachment 241989 [details] patch 2: addressed Geoff's feedback. Please arrange to have UntypedUse be the first thing, as before.

Mark Lam

Comment 6 2014-11-20 15:23:34 PST

Created attachment 241992 [details] patch 3: UntypedUse is at enum 0 again, with extra comments.

Mark Lam

Comment 7 2014-11-20 15:31:45 PST

Created attachment 241995 [details] patch 4: don't like the comment about UntypedUse in last patch. Updated.

Filip Pizlo

Comment 8 2014-11-20 15:33:57 PST

Comment on attachment 241995 [details] patch 4: don't like the comment about UntypedUse in last patch. Updated. You could also have moved all of the other JS representations up with UntypedUse. That would make the most logical sense to me.

Mark Lam

Comment 9 2014-11-20 15:36:49 PST

Created attachment 241996 [details] patch 5: moved al the JSValue representation UseKinds up nelow UntypedUse as Filip suggested.

Mark Lam

Comment 10 2014-11-20 15:40:25 PST

Thanks for the review. Landed in r176425: <http://trac.webkit.org/r176425>.

Note You need to log in before you can comment on or make changes to this bug.