Bug 138931

Summary: Support unprefixed animation event types
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Dean Jackson 2014-11-20 12:45:06 PST 
Support unprefixed animation event types
Comment 1 Dean Jackson 2014-11-20 12:45:29 PST 
<rdar://problem/18943167>
Comment 2 Dean Jackson 2014-11-20 12:47:19 PST 
The approach here is to follow what transitions does:

listener only for old event name -> fire old event name
listener for both old and new event name -> fire new event name
listener only for new event name -> fire new event name

That way pages that were trying to anticipate the new event name won't get duplicate events.
Comment 3 Dean Jackson 2014-11-20 13:11:38 PST 
Created attachment 241973 [details]
Patch
Comment 4 Simon Fraser (smfr) 2014-11-20 13:47:21 PST 
Comment on attachment 241973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241973&action=review

> Source/WebCore/dom/AnimationEvent.cpp:35
> +    , elapsedTime(0.0)

Just 0.

> Source/WebCore/dom/AnimationEvent.cpp:40
> +    : m_elapsedTime(0.0)

Just 0.
Comment 5 Dean Jackson 2014-11-20 14:50:26 PST 
Created attachment 241986 [details]
Patch
Comment 6 Dean Jackson 2014-11-20 15:21:36 PST 
Created attachment 241991 [details]
Patch
Comment 7 Dean Jackson 2014-11-20 15:27:25 PST 
Committed r176423: <http://trac.webkit.org/changeset/176423>
Comment 8 Zoltan Horvath 2014-12-08 09:54:23 PST 
Comment on attachment 241991 [details]
Patch

Clearing flags - pulling it out from the review queue. It was landed earlier in r176423.