Bug 138930

Summary: [iOS] WebKit2 fails to build with public SDK due to missing SPI from CFNetwork, QuartzCore, MediaPlayer, XPC
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit2Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, commit-queue, ddkilzer, eric.carlson, glenn, japhet, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: iOS 8.1   
Bug Depends on:    
Bug Blocks: 137371    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Daniel Bates 2014-11-20 10:43:46 PST 
Add more forward declarations to SPI wrapper headers and make use of existing SPI wrapper headers to fix some WebKit2 compile errors when building with the iOS public SDK.
Comment 1 Daniel Bates 2014-11-20 10:45:59 PST 
Created attachment 241961 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-20 10:48:10 PST 
Attachment 241961 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daniel Bates 2014-11-20 11:55:39 PST 
Created attachment 241967 [details]
Patch

Include file MediaPlayerSPI.h
Comment 4 WebKit Commit Bot 2014-11-20 11:56:50 PST 
Attachment 241967 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Daniel Bates 2014-11-20 13:55:06 PST 
Created attachment 241978 [details]
Patch
Comment 6 WebKit Commit Bot 2014-11-20 13:57:12 PST 
Attachment 241978 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h:113:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Daniel Bates 2014-11-21 08:40:42 PST 
Comment on attachment 241978 [details]
Patch

Clearing flags on attachment: 241978

Committed r176448: <http://trac.webkit.org/changeset/176448>
Comment 8 Daniel Bates 2014-11-21 08:40:47 PST 
All reviewed patches have been landed.  Closing bug.