Bug 138912

Summary: Caret renderer is always a RenderBlock.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2014-11-19 21:11:23 PST
Patch forthcoming.
Attachments
Patch (8.87 KB, patch)
2014-11-19 21:11 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (8.96 KB, patch)
2014-11-19 22:52 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-11-19 21:11:49 PST
Created attachment 241925 [details] Patch
Chris Dumez
Comment 2 2014-11-19 21:30:34 PST
Comment on attachment 241925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241925&action=review > Source/WebCore/editing/FrameSelection.cpp:1361 > + if (RenderBlock* caretPainter = rendererForCaretPainting(node)) auto* ? > Source/WebCore/editing/FrameSelection.cpp:1481 > + if (RenderBlock* renderer = rendererForCaretPainting(node)) auto* ? > Source/WebCore/editing/htmlediting.cpp:1276 > bool paintedByBlock = renderer->isRenderBlockFlow() && caretRendersInsideNode(node); is<RenderBlockFlow>(*renderer) ?
Andreas Kling
Comment 3 2014-11-19 22:52:02 PST
Created attachment 241927 [details] Patch Tweak Chris's tweaks.
Chris Dumez
Comment 4 2014-11-19 22:57:26 PST
Comment on attachment 241927 [details] Patch r=me
WebKit Commit Bot
Comment 5 2014-11-20 00:36:07 PST
Comment on attachment 241927 [details] Patch Clearing flags on attachment: 241927 Committed r176387: <http://trac.webkit.org/changeset/176387>
WebKit Commit Bot
Comment 6 2014-11-20 00:36:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.