Bug 138912

Summary:

Caret renderer is always a RenderBlock.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Andreas Kling 2014-11-19 21:11:23 PST

Patch forthcoming.

Comment 1 Andreas Kling 2014-11-19 21:11:49 PST

Created attachment 241925 [details]
Patch

Comment 2 Chris Dumez 2014-11-19 21:30:34 PST

Comment on attachment 241925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241925&action=review

> Source/WebCore/editing/FrameSelection.cpp:1361
> +    if (RenderBlock* caretPainter = rendererForCaretPainting(node))

auto* ?

> Source/WebCore/editing/FrameSelection.cpp:1481
> +    if (RenderBlock* renderer = rendererForCaretPainting(node))

auto* ?

> Source/WebCore/editing/htmlediting.cpp:1276
>      bool paintedByBlock = renderer->isRenderBlockFlow() && caretRendersInsideNode(node);

is<RenderBlockFlow>(*renderer) ?

Comment 3 Andreas Kling 2014-11-19 22:52:02 PST

Created attachment 241927 [details]
Patch

Tweak Chris's tweaks.

Comment 4 Chris Dumez 2014-11-19 22:57:26 PST

Comment on attachment 241927 [details]
Patch

r=me

Comment 5 WebKit Commit Bot 2014-11-20 00:36:07 PST

Comment on attachment 241927 [details]
Patch

Clearing flags on attachment: 241927

Committed r176387: <http://trac.webkit.org/changeset/176387>

Comment 6 WebKit Commit Bot 2014-11-20 00:36:11 PST

All reviewed patches have been landed.  Closing bug.