Bug 138894

Summary: http tests should not use shared temporary files, part 2
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, mkwst, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138583    
Bug Blocks: 138958    
Attachments:
Description Flags
proposed fix
thorton: review+, ap: commit-queue-
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
none
with a small fix for old PHP none

Description Alexey Proskuryakov 2014-11-19 15:54:12 PST
Missed many tests that write to files outside temporary directory, because they don't use sys_get_temp_dir that I searched for. Yes, these tests write directly to the current directory!
Comment 1 Alexey Proskuryakov 2014-11-19 15:58:02 PST
Created attachment 241902 [details]
proposed fix
Comment 2 Tim Horton 2014-11-19 15:58:59 PST
Comment on attachment 241902 [details]
proposed fix

rs=me
Comment 3 Alexey Proskuryakov 2014-11-19 17:08:53 PST
Comment on attachment 241902 [details]
proposed fix

Some tests are failing, I'll need to see why.
Comment 4 Build Bot 2014-11-19 17:28:44 PST
Comment on attachment 241902 [details]
proposed fix

Attachment 241902 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4902960609886208

New failing tests:
http/tests/security/contentSecurityPolicy/report-only.html
http/tests/security/contentSecurityPolicy/report-and-enforce.html
http/tests/security/contentSecurityPolicy/report-uri.html
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html
http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html
http/tests/security/contentSecurityPolicy/report-only-from-header.php
http/tests/security/contentSecurityPolicy/report-blocked-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
http/tests/security/xssAuditor/report-script-tag.html
http/tests/security/xssAuditor/report-script-tag-full-block.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html
http/tests/security/xssAuditor/report-script-tag-replace-state.html
Comment 5 Build Bot 2014-11-19 17:28:47 PST
Created attachment 241912 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 WebKit Commit Bot 2014-11-19 17:35:47 PST
The commit-queue encountered the following flaky tests while processing attachment 241902 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2014-11-19 17:36:18 PST
The commit-queue encountered the following flaky tests while processing attachment 241902 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 Build Bot 2014-11-19 17:46:50 PST
Comment on attachment 241902 [details]
proposed fix

Attachment 241902 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5692241582489600

New failing tests:
http/tests/security/contentSecurityPolicy/report-only.html
http/tests/security/contentSecurityPolicy/report-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html
http/tests/security/xssAuditor/report-script-tag-replace-state.html
http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html
http/tests/security/contentSecurityPolicy/report-only-from-header.php
http/tests/security/contentSecurityPolicy/report-blocked-uri.html
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html
http/tests/security/xssAuditor/report-script-tag.html
http/tests/security/xssAuditor/report-script-tag-full-block.html
http/tests/security/contentSecurityPolicy/report-and-enforce.html
http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html
Comment 9 Build Bot 2014-11-19 17:46:54 PST
Created attachment 241916 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Alexey Proskuryakov 2014-11-20 10:54:34 PST
Created attachment 241964 [details]
with a small fix for old PHP
Comment 11 WebKit Commit Bot 2014-11-20 14:10:34 PST
Comment on attachment 241964 [details]
with a small fix for old PHP

Clearing flags on attachment: 241964

Committed r176413: <http://trac.webkit.org/changeset/176413>
Comment 12 WebKit Commit Bot 2014-11-20 14:10:40 PST
All reviewed patches have been landed.  Closing bug.