[gdk] Concentrate on browsing and disable editing by changing EditorClientGdk

• Component: New Bugs
• Status: RESOLVED FIXED

[Holger Freyther]

I would like to concentrate on browsing, implementing proper selection etc. first and then eventually get back to editing.

[Holger Freyther]

Created attachment 14744 [details]
Disable editing of HTML

Disable editing to allow me to concentrate on the browsing stuff.

[Maciej Stachowiak]

I think this patch is probably the a good idea, but the reasoning behind it is not quite right. This method is meant to be an override to force whole-view editability. So returning false doesn't prevent all editing, areas marked contentEditable would still allow editing. But it was almost certainly wrong for this method to return "true" in the first place, since it would force all content to always be editable.

[Maciej Stachowiak]

Comment on attachment 14744 [details]
Disable editing of HTML

r=me but you may want to fix the ChangeLog entry to more accurately reflect what this patch actually does.

[Holger Freyther]

I will update the ChangeLog and thank your for your comments.

[Holger Freyther]

Created attachment 14869 [details]
Disable whole-view editing for the Gdk port

Slightly improve the ChangeLog. I sincerly hope it is enough.

[Sam Weinig]

Can you please re-create this patch using svn-create-patch so it can be applied cleanly.

[Holger Freyther]

Created attachment 14888 [details]
Disable whole-view editing for the Gdk port

Created with svn-createPatch now. Would something like git-applyPatch be accepted upstream?

[Mark Rowe (bdash)]

Holger, I think a script to create patches from git that are compatible with svn-apply-patch would be preferred.

[Mark Rowe (bdash)]

Landed in r22088.

[Darin Adler]

Comment on attachment 14888 [details]
Disable whole-view editing for the Gdk port

r=me

I think you could even take out the notImplemented() call -- no special reason you have to offer a whole-view editable mode, thus no reason to keep track of this as a "not implemented" function.