Bug 138880

Summary: Move pseudo-style code from RenderObject to RenderElement.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, mmaxfield, pdr, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2014-11-19 13:24:13 PST
RenderText doesn't have style, so we should really move pseudo style code from RenderObject to RenderElement, too.
Attachments
Patch (22.75 KB, patch)
2014-11-19 13:25 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-11-19 13:25:40 PST
Created attachment 241881 [details] Patch
WebKit Commit Bot
Comment 2 2014-11-19 13:28:00 PST
Attachment 241881 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderElement.h:50: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2014-11-19 15:30:47 PST
Comment on attachment 241881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241881&action=review > Source/WebCore/rendering/RenderElement.cpp:1419 > +RenderStyle* RenderElement::getCachedPseudoStyle(PseudoId pseudo, RenderStyle* parentStyle) const get* naming here is not consistent with the current style, would be nice to fix that too at some point.
WebKit Commit Bot
Comment 4 2014-11-19 16:17:37 PST
Comment on attachment 241881 [details] Patch Clearing flags on attachment: 241881 Committed r176365: <http://trac.webkit.org/changeset/176365>
WebKit Commit Bot
Comment 5 2014-11-19 16:17:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.