Bug 138875

Summary: Add layout test for throttling of DOM timer changing the style of visible and invisible elements
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, kling, koivisto, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138292    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-11-19 10:21:38 PST
Add layout test for throttling of DOM timer changing the style of visible and invisible elements.
Attachments
Patch (3.58 KB, patch)
2014-11-19 10:25 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.31 KB, patch)
2014-11-19 12:28 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-11-19 10:25:30 PST
Created attachment 241868 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-11-19 12:10:41 PST
Comment on attachment 241868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241868&action=review > LayoutTests/ChangeLog:12 > + * fast/dom/repeating-timer-mixed-visible-invisible-elements-throttling-expected.txt: Added. > + * fast/dom/repeating-timer-mixed-visible-invisible-elements-throttling.html: Added. I wouldn't use the term "invisible" for display:none, since there are lots of other ways of making an element not visible. I'd put "display-none" in the test name.
Chris Dumez
Comment 3 2014-11-19 12:18:56 PST
Comment on attachment 241868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241868&action=review >> LayoutTests/ChangeLog:12 >> + * fast/dom/repeating-timer-mixed-visible-invisible-elements-throttling.html: Added. > > I wouldn't use the term "invisible" for display:none, since there are lots of other ways of making an element not visible. I'd put "display-none" in the test name. You did not complain last time :) http://trac.webkit.org/changeset/176239 I will rename the existing tests as well then for clarity / consistency.
Chris Dumez
Comment 4 2014-11-19 12:28:50 PST
Created attachment 241877 [details] Patch
WebKit Commit Bot
Comment 5 2014-11-19 13:14:51 PST
Comment on attachment 241877 [details] Patch Clearing flags on attachment: 241877 Committed r176333: <http://trac.webkit.org/changeset/176333>
WebKit Commit Bot
Comment 6 2014-11-19 13:14:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.