Bug 138838

Summary: DOMTimers sometimes don't get unthrottled on scrolling
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, kling, koivisto, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138292    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2014-11-18 11:29:14 PST 
DOMTimers sometimes don't get unthrottled on scrolling. This is because we stop listening for viewport changes every time the timer fires, but we don't listen for those changes again if we decide the timer should stay throttled after the timer's action was executed.
We should listen for viewport changes again after executing the action, if there are elements outside the viewport causing the DOMTimer to be throttled, even if the throttleState hasn't changed.
Comment 1 Chris Dumez 2014-11-18 12:12:21 PST 
Created attachment 241801 [details]
Patch
Comment 2 Chris Dumez 2014-11-18 13:27:40 PST 
Comment on attachment 241801 [details]
Patch

Thanks for reviewing quickly.
Comment 3 WebKit Commit Bot 2014-11-18 14:05:02 PST 
Comment on attachment 241801 [details]
Patch

Clearing flags on attachment: 241801

Committed r176282: <http://trac.webkit.org/changeset/176282>
Comment 4 WebKit Commit Bot 2014-11-18 14:05:08 PST 
All reviewed patches have been landed.  Closing bug.