Summary: | [GTK] LDFLAGS is ignored when running g-ir-scanner | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ting-Wei Lan <lantw44> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | berto, cgarcia, commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Other | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 138833 | ||||||||||
Attachments: |
|
Description
Ting-Wei Lan
2014-11-18 05:37:16 PST
Created attachment 241784 [details]
[GTK] LDFLAGS is ignored when running g-ir-scanner
This patch is required to build WebKitGTK+ 2.6.x and 2.7.x on FreeBSD. Created attachment 242219 [details]
[GTK] LDFLAGS is ignored when running g-ir-scanner
Comment on attachment 242219 [details] [GTK] LDFLAGS is ignored when running g-ir-scanner View in context: https://bugs.webkit.org/attachment.cgi?id=242219&action=review > Source/WebKit2/PlatformGTK.cmake:757 > +# Add required -L flags from ${CMAKE_SHARED_LINKER_FLAGS} for g-ir-scanner > +separate_arguments(INTROSPECTION_ADDITIONAL_LINKER_FLAGS > + UNIX_COMMAND ${CMAKE_SHARED_LINKER_FLAGS}) > +foreach (linker_flag ${INTROSPECTION_ADDITIONAL_LINKER_FLAGS}) > + string(REGEX MATCH "-L[^ ]*" linker_flag_matched "${linker_flag}") > + string(COMPARE EQUAL "${linker_flag_matched}" "" linker_flag_not_allowed) > + if (linker_flag_not_allowed) > + list(REMOVE_ITEM INTROSPECTION_ADDITIONAL_LINKER_FLAGS "${linker_flag}") > + endif () > +endforeach (linker_flag) > + Isn't it easier to do this instead? string(REGEX MATCHALL "-L[^ ]*" INTROSPECTION_ADDITIONAL_LINKER_FLAGS ${CMAKE_SHARED_LINKER_FLAGS}) Created attachment 242891 [details]
[GTK] LDFLAGS is ignored when running g-ir-scanner
(In reply to comment #5) > Created attachment 242891 [details] > [GTK] LDFLAGS is ignored when running g-ir-scanner I think that looks much better, thanks! Comment on attachment 242891 [details] [GTK] LDFLAGS is ignored when running g-ir-scanner Clearing flags on attachment: 242891 Committed r177016: <http://trac.webkit.org/changeset/177016> All reviewed patches have been landed. Closing bug. |