Bug 138824

Summary: Update the Vector API to deal with unsigned types instead of size_t
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, kling, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch none

Description Chris Dumez 2014-11-17 23:19:31 PST 
Update the Vector API to deal with unsigned types instead of size_t. Vector already uses unsigned for its size / capacity members but the API was never updated accordingly.
Comment 1 Chris Dumez 2014-11-17 23:37:06 PST 
Created attachment 241768 [details]
WIP Patch
Comment 2 WebKit Commit Bot 2014-11-17 23:38:09 PST 
Attachment 241768 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Vector.h:199:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-11-17 23:41:31 PST 
Created attachment 241769 [details]
WIP Patch
Comment 4 Chris Dumez 2014-11-18 09:40:56 PST 
Created attachment 241792 [details]
Patch
Comment 5 Andreas Kling 2014-11-18 11:17:58 PST 
Comment on attachment 241792 [details]
Patch

I owe you a $beverage! r=me
Comment 6 WebKit Commit Bot 2014-11-18 11:55:54 PST 
Comment on attachment 241792 [details]
Patch

Clearing flags on attachment: 241792

Committed r176275: <http://trac.webkit.org/changeset/176275>
Comment 7 WebKit Commit Bot 2014-11-18 11:55:59 PST 
All reviewed patches have been landed.  Closing bug.