Bug 138823

Summary:

crypto: Use sequence<> instead of KeyUsage[] in IDL

Product:

WebKit

Reporter:

Shivakumar J M <shiva.jm>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, darin, gyuyoung.kim, pnormand, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Shivakumar J M 2014-11-17 22:36:21 PST

Use sequence<> instead of KeyUsage[] in crypto IDL as per spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#SubtleCrypto-method-generateKey

Comment 1 Shivakumar J M 2014-11-17 22:54:45 PST

Created attachment 241766 [details]
Patch

Use sequence<KeyUsage> instead of KeyUsage[] in crypto IDL as per spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#SubtleCrypto-method-generateKey

Comment 2 WebKit Commit Bot 2014-11-18 09:44:58 PST

Comment on attachment 241766 [details]
Patch

Clearing flags on attachment: 241766

Committed r176261: <http://trac.webkit.org/changeset/176261>

Comment 3 WebKit Commit Bot 2014-11-18 09:45:02 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Alexey Proskuryakov 2014-11-18 10:14:31 PST

Is KeyUsage[] exactly the same thing as sequence<KeyUsage>? Otherwise, the change may be wrong, as it only changes description in IDL, but does not change what WebKit actually does.