Bug 138822

Summary: Add the initial implementation of dynamic specificity for :matches()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
none
Patch kling: review+

Description Benjamin Poulain 2014-11-17 21:34:38 PST
Add the initial implementation of dynamic specificity for :matches()
Comment 1 Benjamin Poulain 2014-11-17 21:45:03 PST
Created attachment 241763 [details]
Patch
Comment 2 Build Bot 2014-11-17 22:49:48 PST
Comment on attachment 241763 [details]
Patch

Attachment 241763 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4997228900909056

New failing tests:
fast/selectors/class-style-update-with-not.html
Comment 3 Build Bot 2014-11-17 22:49:51 PST
Created attachment 241765 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-11-17 23:25:30 PST
Comment on attachment 241763 [details]
Patch

Attachment 241763 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5780118559522816

New failing tests:
fast/selectors/class-style-update-with-not.html
Comment 5 Build Bot 2014-11-17 23:25:34 PST
Created attachment 241767 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Benjamin Poulain 2014-11-18 17:29:20 PST
Created attachment 241838 [details]
Patch
Comment 7 Andreas Kling 2014-11-18 21:04:39 PST
Comment on attachment 241838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241838&action=review

r=me

> Source/WebCore/css/CSSSelector.cpp:83
> +    // FIXME: get rid of this!

:|
Comment 8 Benjamin Poulain 2014-11-18 21:12:43 PST
Committed r176307: <http://trac.webkit.org/changeset/176307>