Bug 138817

Summary: Avoid re-encoding action menu image data
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, bdakin, conrad_shultz, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Tim Horton
Reported 2014-11-17 18:26:43 PST
Avoid re-encoding action menu image data
Attachments
Patch (15.29 KB, patch)
2014-11-17 18:27 PST, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-17 18:27:20 PST
Created attachment 241756 [details] Patch
Beth Dakin
Comment 2 2014-11-17 20:11:00 PST
Do we want to mimic any of this in WK1 code? WebActionMenuController also still hardcodes jpg even though it probably already have enough information to avoid that.
Tim Horton
Comment 3 2014-11-17 23:30:55 PST
(In reply to comment #2) > Do we want to mimic any of this in WK1 code? WebActionMenuController also > still hardcodes jpg even though it probably already have enough information > to avoid that. This patch fixes both WebKits.
Anders Carlsson
Comment 4 2014-11-18 11:03:27 PST
Comment on attachment 241756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241756&action=review > Source/WebKit/mac/WebView/WebActionMenuController.mm:415 > + RefPtr<SharedBuffer> buffer = image->data(); Can buffer ever be null here?
Tim Horton
Comment 5 2014-11-18 14:55:07 PST
http://trac.webkit.org/changeset/176288
Alexey Proskuryakov
Comment 6 2014-11-18 22:10:46 PST
Does this bring image codec code execution vulnerabilities into UI process?
Note You need to log in before you can comment on or make changes to this bug.