Bug 138804

Summary:

AX: Screen braille input doesn't work on forms.

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, commit-queue, dmazzoni, jcraig, jdiggs, mario, ossy, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch	none

Description chris fleizach 2014-11-17 12:19:25 PST

Using the VoiceOver Braille screen input method on text fields in Safari doesn't work because accessibilitySetValue is not implemented

<rdar://problem/18402695>

Comment 1 chris fleizach 2014-11-17 12:22:37 PST

Created attachment 241732 [details]
patch

Comment 2 Mario Sanchez Prada 2014-11-18 02:28:17 PST

Comment on attachment 241732 [details]
patch

Is it possible to include a test?

Comment 3 chris fleizach 2014-11-18 15:45:20 PST

Created attachment 241822 [details]
patch

Comment 4 chris fleizach 2014-11-18 15:45:52 PST

Test added

Comment 5 WebKit Commit Bot 2014-11-19 07:47:07 PST

Comment on attachment 241822 [details]
patch

Clearing flags on attachment: 241822

Committed r176318: <http://trac.webkit.org/changeset/176318>

Comment 6 WebKit Commit Bot 2014-11-19 07:47:11 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Csaba Osztrogonác 2014-11-19 13:59:29 PST

(In reply to comment #5)
> Comment on attachment 241822 [details]
> patch
> 
> Clearing flags on attachment: 241822
> 
> Committed r176318: <http://trac.webkit.org/changeset/176318>

It broke the Apple Windows build, as the EWS noticed it before landing.

Comment 8 chris fleizach 2014-11-19 14:01:30 PST

(In reply to comment #7)
> (In reply to comment #5)
> > Comment on attachment 241822 [details]
> > patch
> > 
> > Clearing flags on attachment: 241822
> > 
> > Committed r176318: <http://trac.webkit.org/changeset/176318>
> 
> It broke the Apple Windows build, as the EWS noticed it before landing.

Build output from windows was incomprehensible. I could not even find the error when I looked, which indicated to me that it was a false positive. 

I will look at this now. thanks

Comment 9 chris fleizach 2014-11-19 14:04:26 PST

Here's the windows failure, which tells me nothing about what failed
---------
Build started 11/19/2014 6:53:53 AM.
     1>Project "C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\TestWebKitAPI.vcxproj" on node 5 (Build target(s)).
     1>PreBuildEvent:
         REM Do not edit from the Visual Studio IDE! Customize via a TestWebKitAPIPreBuild.cmd file.
         if not exist "C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\TestWebKitAPIPreBuild.cmd" exit /b
         
         set CONFIGURATIONBUILDDIR=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release
         set CONFIGURATIONNAME=Release
         set INPUTDIR=
         set INPUTFILENAME=
         set INPUTPATH=
         set INTDIR=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj32\TestWebKitAPI\
         set OUTDIR=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\
         set PLATFORMARCHITECTURE=32
         set PLATFORMNAME=Win32
         set PROJECTDIR=C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\
         set PROJECTFILENAME=TestWebKitAPI.vcxproj
         set PROJECTNAME=TestWebKitAPI
         set PROJECTPATH=C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\TestWebKitAPI.vcxproj
         set SOLUTIONDIR=C:\cygwin\home\buildbot\WebKit\Source\WebKit\WebKit.vcxproj\
         set SOLUTIONFILENAME=WebKit.sln
         set SOLUTIONNAME=WebKit
         set SOLUTIONPATH=C:\cygwin\home\buildbot\WebKit\Source\WebKit\WebKit.vcxproj\WebKit.sln
         set TARGETDIR=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\
         set TARGETEXT=.exe
         set TARGETFILENAME=TestWebKitAPI.exe
         set TARGETPATH=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\TestWebKitAPI.exe
         set DEBUGSUFFIX=
         set WEBKIT_LIBRARIES=C:\cygwin\home\buildbot\WebKit\WebKitLibraries\win
         
         REM If any of the above variables didn't exist previously and
         REM were set to an empty string, set will set the errorlevel to 1,
         REM which will cause the project-specific script to think the build
         REM has failed. This cmd /c call will clear the errorlevel.
         cmd /c
         
         "C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\TestWebKitAPIPreBuild.cmd"
         
         :VCEnd
         /usr/bin/perl
     1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: The command "REM Do not edit from the Visual Studio IDE! Customize via a TestWebKitAPIPreBuild.cmd file.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: if not exist "C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\TestWebKitAPIPreBuild.cmd" exit /b
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: 
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set CONFIGURATIONBUILDDIR=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set CONFIGURATIONNAME=Release
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set INPUTDIR=
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set INPUTFILENAME=
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set INPUTPATH=
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set INTDIR=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj32\TestWebKitAPI\
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set OUTDIR=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set PLATFORMARCHITECTURE=32
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set PLATFORMNAME=Win32
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set PROJECTDIR=C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set PROJECTFILENAME=TestWebKitAPI.vcxproj
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set PROJECTNAME=TestWebKitAPI
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set PROJECTPATH=C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\TestWebKitAPI.vcxproj
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set SOLUTIONDIR=C:\cygwin\home\buildbot\WebKit\Source\WebKit\WebKit.vcxproj\
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set SOLUTIONFILENAME=WebKit.sln
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set SOLUTIONNAME=WebKit
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set SOLUTIONPATH=C:\cygwin\home\buildbot\WebKit\Source\WebKit\WebKit.vcxproj\WebKit.sln
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set TARGETDIR=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set TARGETEXT=.exe
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set TARGETFILENAME=TestWebKitAPI.exe
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set TARGETPATH=C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\TestWebKitAPI.exe
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set DEBUGSUFFIX=
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: set WEBKIT_LIBRARIES=C:\cygwin\home\buildbot\WebKit\WebKitLibraries\win
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: 
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: REM If any of the above variables didn't exist previously and
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: REM were set to an empty string, set will set the errorlevel to 1,
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: REM which will cause the project-specific script to think the build
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: REM has failed. This cmd /c call will clear the errorlevel.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: cmd /c
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: 
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: "C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\TestWebKitAPIPreBuild.cmd"
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: 
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(122,5): error MSB3073: :VCEnd" exited with code 1.
     1>Done Building Project "C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\TestWebKitAPI.vcxproj\TestWebKitAPI.vcxproj" (Build target(s)) -- FAILED.

Build FAILED.

Time Elapsed 00:00:00.07


===== BUILD FAILED ======

Comment 10 chris fleizach 2014-11-19 14:05:06 PST

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #5)
> > > Comment on attachment 241822 [details]
> > > patch
> > > 
> > > Clearing flags on attachment: 241822
> > > 
> > > Committed r176318: <http://trac.webkit.org/changeset/176318>
> > 
> > It broke the Apple Windows build, as the EWS noticed it before landing.
> 
> Build output from windows was incomprehensible. I could not even find the
> error when I looked, which indicated to me that it was a false positive. 
> 
> I will look at this now. thanks

It looks like the build servers are also not that helpful.

Csaba, do you have the actual build failure anywhere?

Comment 11 chris fleizach 2014-11-19 14:12:31 PST

build fix i hope
http://trac.webkit.org/changeset/176343

Comment 12 Csaba Osztrogonác 2014-11-19 23:37:20 PST

(In reply to comment #8)
> Build output from windows was incomprehensible. I could not even find the
> error when I looked, which indicated to me that it was a false positive. 
> 
> I will look at this now. thanks

You could have found this in the EWS output and the buildbot log too: 
     1>..\..\AccessibilityUIElement.cpp(1353): error C2761: 'void AccessibilityUIElement::setValue(JSStringRef)' : member function redeclaration not allowed
( https://webkit-queues.appspot.com/results/6023295849725952 
 https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/65518/steps/compile-webkit/logs/stdio )

If you didn't find the " error " word, it doesn't mean if it was false redness.
Otherwise http://trac.webkit.org/changeset/176343 fixed it, thanks.