Bug 138787

Summary: [iOS] allow host application to opt-out of alternate fullscreen
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, mitz, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. darin: review+

Eric Carlson
Reported 2014-11-16 19:32:42 PST
Allow the host application to enable/disable alternate ("optimized") fullscreen mode.
Attachments
Proposed patch. (17.51 KB, patch)
2014-11-16 19:48 PST, Eric Carlson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-11-16 19:35:16 PST
<rdar://problem/18687640>
Eric Carlson
Comment 2 2014-11-16 19:48:54 PST
Created attachment 241686 [details] Proposed patch.
WebKit Commit Bot
Comment 3 2014-11-16 19:51:08 PST
Attachment 241686 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 4 2014-11-16 20:13:01 PST
Comment on attachment 241686 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=241686&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). You’ll have to remove this line. Or replace it with an explanation of why we didn’t add a test for this.
Eric Carlson
Comment 5 2014-11-17 06:07:43 PST
Committed r176199: https://trac.webkit.org/r176199
mitz
Comment 6 2014-11-17 07:17:20 PST
Comment on attachment 241686 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=241686&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h:108 > +@property (nonatomic) BOOL allowsAlternateFullscreen; This new API is missing an availability annotation. It should be WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA).
Eric Carlson
Comment 7 2014-11-18 14:12:41 PST
(In reply to comment #6) > Comment on attachment 241686 [details] > Proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241686&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h:108 > > +@property (nonatomic) BOOL allowsAlternateFullscreen; > > This new API is missing an availability annotation. It should be > WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA). Thanks for the reminder. Upon reflection this doesn't need to be public, so I will move it into the private header.
Eric Carlson
Comment 8 2014-11-18 14:13:01 PST
Committed r176283: https://trac.webkit.org/r176283
Note You need to log in before you can comment on or make changes to this bug.