Bug 138765

Summary: Implement data detectors and mailto action menus for WebKit1
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, mitz, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Tim Horton
Reported 2014-11-14 18:25:49 PST
Implement data detectors and mailto action menus for WebKit1
Attachments
Patch (13.00 KB, patch)
2014-11-14 18:26 PST, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-14 18:26:25 PST
Created attachment 241653 [details] Patch
Tim Horton
Comment 2 2014-11-14 18:28:13 PST
rdar://problem/18877535
WebKit Commit Bot
Comment 3 2014-11-14 18:29:33 PST
Attachment 241653 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:535: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:537: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 4 2014-11-14 23:49:28 PST
Comment on attachment 241653 [details] Patch YAY
Tim Horton
Comment 5 2014-11-15 00:13:35 PST
http://trac.webkit.org/changeset/176153
Note You need to log in before you can comment on or make changes to this bug.