Bug 138765

Summary: Implement data detectors and mailto action menus for WebKit1
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, mitz, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Description Tim Horton 2014-11-14 18:25:49 PST
Implement data detectors and mailto action menus for WebKit1
Comment 1 Tim Horton 2014-11-14 18:26:25 PST
Created attachment 241653 [details]
Patch
Comment 2 Tim Horton 2014-11-14 18:28:13 PST
rdar://problem/18877535
Comment 3 WebKit Commit Bot 2014-11-14 18:29:33 PST
Attachment 241653 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:535:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:536:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:537:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Beth Dakin 2014-11-14 23:49:28 PST
Comment on attachment 241653 [details]
Patch

YAY
Comment 5 Tim Horton 2014-11-15 00:13:35 PST
http://trac.webkit.org/changeset/176153