Bug 138754

Summary: Remove computeTextPaintStyle's RenderText dependency.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2014-11-14 13:58:21 PST
from
TextPaintStyle computeTextPaintStyle(const RenderText&, const RenderStyle&, const PaintInfo&);
to
TextPaintStyle computeTextPaintStyle(const Frame&, const RenderStyle&, const PaintInfo&);

So that in simple line layout, we can compute text paint style without across multiple renderers.
Comment 1 zalan 2014-11-14 14:05:22 PST
Created attachment 241622 [details]
Patch
Comment 2 Myles C. Maxfield 2014-11-14 14:18:47 PST
Why is frame better than RenderText?

unofficial r=me
Comment 3 WebKit Commit Bot 2014-11-14 16:26:53 PST
Comment on attachment 241622 [details]
Patch

Clearing flags on attachment: 241622

Committed r176147: <http://trac.webkit.org/changeset/176147>
Comment 4 WebKit Commit Bot 2014-11-14 16:26:57 PST
All reviewed patches have been landed.  Closing bug.